Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

[Ian Delaney <idella4@gentoo.org>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On Sat, 7 May 2016 23:25:58 +0200
Michał Górny <mgorny@gentoo.org> wrote:

> On Sat,  7 May 2016 21:19:31 +0000 (UTC)
> "Joerg Bornkessel" <hd_brummy@gentoo.org> wrote:
> 
> > commit:     66afcab271f65b97330e610040ad3acc1b812a03
> > Author:     Joerg Bornkessel <hd_brummy <AT> gentoo <DOT> org>
> > AuthorDate: Sat May  7 21:18:48 2016 +0000
> > Commit:     Joerg Bornkessel <hd_brummy <AT> gentoo <DOT> org>
> > CommitDate: Sat May  7 21:18:48 2016 +0000
> > URL:
> > https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=66afcab2
> > 
> > fixed einstall vs. emake install for eapi=6
> > 
> >  eclass/vdr-plugin-2.eclass | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> > 
> > diff --git a/eclass/vdr-plugin-2.eclass b/eclass/vdr-plugin-2.eclass
> > index ae09a34..65f1409 100644
> > --- a/eclass/vdr-plugin-2.eclass
> > +++ b/eclass/vdr-plugin-2.eclass
> > @@ -571,7 +571,11 @@ vdr-plugin-2_src_install() {
> >  	local SOFILE_STRING=$(grep SOFILE Makefile)
> >  	if [[ -n ${SOFILE_STRING} ]]; then
> >  		BUILD_TARGETS=${BUILD_TARGETS:-${VDRPLUGIN_MAKE_TARGET:-install }}
> > -		einstall ${BUILD_PARAMS} \
> > +		if [[ ${EAPI} == 6 ]]; then
> > +			emake install ${BUILD_PARAMS} \
> > +		else
> > +			einstall ${BUILD_PARAMS} \
> > +		fi
> >  			${BUILD_TARGETS} \
> >  			TMPDIR="${T}" \
> >  			DESTDIR="${D}" \
> >   
> 
> Do you seriously expect this code to work? How about testing? Or
> reading diffs before committing?
> 

Do you seriously expect us to sit and absorb this form of pious
put down? From one who knows far better who is entitled to speak down
to colleagues as is completely lacking a cerebral cortex? Those times
are drawing to an end. Did anyone ever teach you to treat folk in such
manner and expect them to respect it? I don't think so
Not over my dead cvs perhaps

- -- 
kind regards

Ian Delaney
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.1

iQJ8BAEBCgBmBQJXNZW5XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRCRUI4RjAxNzRGRTVDMjI4RjcxNkRFNzIw
QzQzN0NCNDcxRTlEMzNBAAoJEAxDfLRx6dM6mzcP/1BmrZw/EiuPlJh6MuufJ1/U
Zlg26d99Vvvji0VVHcz9lrDhk6ubYB3WrcrG3E2M1pVwXDTuy+z5ez7RXvuUMSSY
XiP4uWVWmlQoBlkAzAAvzKKVNsQvfOCif1x/b59Qjm9qAKQOwawTzCjOCHIrB08V
EXFuuo5gpHfkq5vtU7jK22/6Zo56w+A7xfgSKl96byepA4F++3vDH4kX3XTBVmtE
vlPn230CQqgP/YMZ/TBcQ4AE3r0fxPmGnAniZn/o5v2Zpzo1SZjrRlYJXDq3PnIa
Rjs6fWEvfA7xu8wDt05Xz+8bzVXmS//1ga0VB1dmcNlVelUY7Pwi1kR+nUF174Vo
/xLlTvK/EboliAMbviRwX9extWycWCB+iyBH/RkazaQQmSiW5tHlVPx8Wu7LiRay
O8eFks7LgenetNBymMaiPBNZJMo/I+Fnebk43qx0XfUyuANLsg3JnsY4WG+Evcjc
3XqkTePuDyFLQEgQlU417JSFRkyZ0odMqpVShqOxgv4EA/HAiCpWCHkE1ZuiLi1V
7bKQodOclD3jTmy6eJgLpoEhqphXCaX9bl5QcFyu3+La8r3YXOqErCbOECoJy0Np
lXwOCKZ9kvcv8iLygxKqP/0rxuAP0kzs5NSWd2zhHLRBihNvP+xkc2Pi4ztRT2LN
Hju+wa0/WdLLTEPCAe78
=4iJI
-----END PGP SIGNATURE-----