From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 86776138252 for ; Wed, 11 May 2016 02:51:35 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id A20B5E0880; Wed, 11 May 2016 02:51:21 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id AC2DFE0810 for ; Wed, 11 May 2016 02:51:20 +0000 (UTC) Received: from professor-x (S010634bdfa9ecf80.vc.shawcable.net [96.49.31.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: dolsen) by smtp.gentoo.org (Postfix) with ESMTPSA id 40018340B54 for ; Wed, 11 May 2016 02:51:18 +0000 (UTC) Date: Tue, 10 May 2016 19:50:29 -0700 From: Brian Dolbec To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH] ebuild-writing/variables: better describe ROOT Message-ID: <20160510195029.3e0fb491.dolsen@gentoo.org> In-Reply-To: References: <1462729330-24788-1-git-send-email-floppym@gentoo.org> <5731F960.50205@gentoo.org> <573251B8.8090103@gentoo.org> <20160510185415.742432c3.dolsen@gentoo.org> Organization: Gentoo Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Archives-Salt: 1ec24b96-4114-4468-be5a-62878d80d277 X-Archives-Hash: cc761dcfefc12a3c7fd8510c850f7693 On Tue, 10 May 2016 22:40:39 -0400 Mike Gilbert wrote: > On Tue, May 10, 2016 at 9:54 PM, Brian Dolbec > wrote: > >> I agree, repoman should be catching this stuff. > >> > > > > Then Please contribute some test ebuilds for the gen-b0rk repo to > > test repoman or any other Q/A apps with. If they fail to detect > > the test ebuilds, it will give us something to use to help trace > > the code errors. It'll also make for a much better testing system > > overall for any app performing any type of Q/A on ebuilds. > > I don't think there is a repoman check for ROOT in src functions > (yet). I was just saying that I think it would make sense to add that. > As you know, with the modular system now in place, It should be quite easy to add that check now. There is no need to figure out where in over 3000 lines of spaghetti code to insert it without messing up something else. Make the test ebuilds, at least one good one, plus however many to test the broken parts. It should only take an hour to add that check. -- Brian Dolbec