Re: [gentoo-dev] [PATCH] ebuild-writing/variables: better describe ROOT

[Brian Dolbec <dolsen@gentoo.org>]

On Tue, 10 May 2016 22:40:39 -0400
Mike Gilbert <floppym@gentoo.org> wrote:

> On Tue, May 10, 2016 at 9:54 PM, Brian Dolbec <dolsen@gentoo.org>
> wrote:
> >> I agree, repoman should be catching this stuff.
> >>  
> >
> > Then Please contribute some test ebuilds for the gen-b0rk repo to
> > test repoman or any other Q/A apps with.  If they fail to detect
> > the test ebuilds, it will give us something to use to help trace
> > the code errors. It'll also make for a much better testing system
> > overall for any app performing any type of Q/A on ebuilds.  
> 
> I don't think there is a repoman check for ROOT in src functions
> (yet). I was just saying that I think it would make sense to add that.
> 

As you know, with the modular system now in place, It should be quite
easy to add that check now.  There is no need to figure out where in
over 3000 lines of spaghetti code to insert it without messing up
something else.

Make the test ebuilds, at least one good one, plus however many to test
the broken parts.  It should only take an hour to add that check.

-- 
Brian Dolbec <dolsen>