public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Brian Dolbec <dolsen@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] On banning merge commits
Date: Sun, 8 May 2016 05:53:42 -0700	[thread overview]
Message-ID: <20160508055342.24ec8c9f.dolsen@gentoo.org> (raw)
In-Reply-To: <8760uoj23y.fsf@freja.aidecoe.name>

[-- Attachment #1: Type: text/plain, Size: 1044 bytes --]

On Sun, 08 May 2016 11:06:09 +0100
Amadeusz Żołnowski <aidecoe@gentoo.org> wrote:

> I am working at the moment on debundling ejabberd. It will come with
> ~30 packages and I will do "git merge --no-ff ejabberd-debundled"
> because it will actually look less messy.
> 
> Thanks,
> -- Amadeusz Żołnowski


Yes, this is exactly the type of merge commits that should be allowed.

Not the one or two user PR commits that might be based on a weeks old
tree, that a developer merges without rebasing.  It is these merge
commits which have caused all the grief we've experienced over merge
commits.

Merge commits should be used wisely and for larger branch merges like
the kde, gnome team's development overlay merges to the main tree or
similar larger one off project's like the one above.  It is these
larger commit branches that are much more difficult to "git pull
--rebase && git push --signed" successfully without some other pushes in
between causing a rejected non-fast forward push.
-- 
Brian Dolbec <dolsen>


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 951 bytes --]

  reply	other threads:[~2016-05-08 12:54 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-07 23:52 [gentoo-dev] On banning merge commits Patrice Clement
2016-05-08  5:09 ` Michał Górny
2016-05-08  5:44   ` cbergstrom
2016-05-08  8:21     ` Greg KH
2016-05-08  9:35       ` Daniel Campbell
2016-05-08  8:58     ` [gentoo-dev] " Duncan
2016-05-08  9:25       ` Kent Fredric
2016-05-08 10:21         ` Duncan
2016-05-08 10:35         ` Dirkjan Ochtman
2016-05-08 10:30   ` [gentoo-dev] " Dirkjan Ochtman
2016-05-08 12:00     ` Michał Górny
2016-05-08 12:31       ` Dirkjan Ochtman
2016-05-08 11:13   ` Andreas K. Hüttel
2016-05-08 11:28     ` M. J. Everitt
2016-05-08  9:15 ` Andrew Savchenko
2016-05-08 10:06 ` Amadeusz Żołnowski
2016-05-08 12:53   ` Brian Dolbec [this message]
2016-05-08 15:15     ` Jeroen Roovers
2016-05-08 22:25     ` Daniel Campbell
2016-05-08 11:25 ` Andreas K. Hüttel
2016-05-08 11:57   ` Rich Freeman
2016-05-08 12:07     ` Kent Fredric
2016-05-08 21:56     ` [gentoo-dev] " Duncan
2016-05-08 12:09   ` [gentoo-dev] " Anthony G. Basile
2016-05-08 12:18     ` Kent Fredric
2016-05-08 12:34       ` Rich Freeman
2016-05-08 12:43         ` Anthony G. Basile
2016-05-08 22:02         ` [gentoo-dev] " Duncan
2016-05-08 17:03 ` [gentoo-dev] " Alexis Ballier
2016-05-08 17:07   ` Kent Fredric
2016-05-09 11:27     ` Kristian Fiskerstrand
2016-05-09 12:23       ` Rich Freeman
2016-05-09 12:36         ` Kent Fredric
2016-05-09 12:59           ` Rich Freeman
2016-05-10 12:04     ` Alexis Ballier
2016-05-10 14:18       ` Kent Fredric
2016-05-11 10:21         ` Alexis Ballier
2016-05-11 14:34           ` Kent Fredric
2016-05-11 15:12             ` Rich Freeman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160508055342.24ec8c9f.dolsen@gentoo.org \
    --to=dolsen@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox