From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 0734813824A for ; Sat, 7 May 2016 21:26:15 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 81B36E086D; Sat, 7 May 2016 21:26:10 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 75E7DE085B for ; Sat, 7 May 2016 21:26:09 +0000 (UTC) Received: from pomiot (d202-252.icpnet.pl [109.173.202.252]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 8C06D340139; Sat, 7 May 2016 21:26:07 +0000 (UTC) Date: Sat, 7 May 2016 23:25:58 +0200 From: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= To: "Joerg Bornkessel" Cc: gentoo-dev@lists.gentoo.org Subject: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/ Message-ID: <20160507232558.1995dff5.mgorny@gentoo.org> In-Reply-To: <1462655928.66afcab271f65b97330e610040ad3acc1b812a03.hd_brummy@gentoo> References: <1462655928.66afcab271f65b97330e610040ad3acc1b812a03.hd_brummy@gentoo> Organization: Gentoo X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/1vkIXg4msSQ2yfcXberrHK_"; protocol="application/pgp-signature" X-Archives-Salt: 5b77bbc7-e4ad-45e1-8b3f-e74c081e9040 X-Archives-Hash: f54a5175df0844ff5c17eba54aab279c --Sig_/1vkIXg4msSQ2yfcXberrHK_ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sat, 7 May 2016 21:19:31 +0000 (UTC) "Joerg Bornkessel" wrote: > commit: 66afcab271f65b97330e610040ad3acc1b812a03 > Author: Joerg Bornkessel gentoo org> > AuthorDate: Sat May 7 21:18:48 2016 +0000 > Commit: Joerg Bornkessel gentoo org> > CommitDate: Sat May 7 21:18:48 2016 +0000 > URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3D66afca= b2 >=20 > fixed einstall vs. emake install for eapi=3D6 >=20 > eclass/vdr-plugin-2.eclass | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) >=20 > diff --git a/eclass/vdr-plugin-2.eclass b/eclass/vdr-plugin-2.eclass > index ae09a34..65f1409 100644 > --- a/eclass/vdr-plugin-2.eclass > +++ b/eclass/vdr-plugin-2.eclass > @@ -571,7 +571,11 @@ vdr-plugin-2_src_install() { > local SOFILE_STRING=3D$(grep SOFILE Makefile) > if [[ -n ${SOFILE_STRING} ]]; then > BUILD_TARGETS=3D${BUILD_TARGETS:-${VDRPLUGIN_MAKE_TARGET:-install }} > - einstall ${BUILD_PARAMS} \ > + if [[ ${EAPI} =3D=3D 6 ]]; then > + emake install ${BUILD_PARAMS} \ > + else > + einstall ${BUILD_PARAMS} \ > + fi > ${BUILD_TARGETS} \ > TMPDIR=3D"${T}" \ > DESTDIR=3D"${D}" \ >=20 Do you seriously expect this code to work? How about testing? Or reading diffs before committing? --=20 Best regards, Micha=C5=82 G=C3=B3rny --Sig_/1vkIXg4msSQ2yfcXberrHK_ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ7BAEBCgBmBQJXLl1mXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ2REJCMDdDQzRGMERBRDA2RUEwQUZFNDFC MDdBMUFFQUVGQjQ0NjRFAAoJELB6GurvtEZOcMIP93ohYiNALpjyVwKXAFKNBVcD HlDCofGu+96SiOKsvoSHPmCdg08uDKojW765Z7C6w8M5jSnDyXPsyruQ9aJi9a5n HYl8MXMZfKzw2XEE/5pMRFr4b0oIuEK14lzgOG+JOvbYzvIFQbCgWznpBnKp+TGS 8YjQqEgHMZGIG0vBK+4fQugXil1We/ewrGgag+ED9x774TuDGcEF/Fymxpj339zS J6xwzerOr1wW4DR9wiOn84P6ODwhGKXQzVgAz3n4cv9I+4Nk5KoG2qlCX6VHMMN+ ohgr2KrZHM7Aaz1v9IjVKNCx01FxITCpXDjVpc85lKPnk8/yy1QYEkewgus+azhf mi5N9s/rlV252zGxZbbYn3iOTQc9AUdHb9FhKgDJckv+DcyeBY6imx5wG+qF21Tn dxKQ3c/o6uMvARV5vkxq/mteqjprcXXOFRJrvIyzcaMNijnaXnK10GCxaaaXMw+d 6G0ykpcJxwiMMPmH5ck/1MZ9Ev8PLyWOHUeEBAG1m/zjXIkq2NzrQUM8O5WSV6QB wkqtWDRBjiOlZ+V6TEqRuX7P6vCMxRMsTlsW9emgIqnyybabGpOAda5YMPCuu4MT V0qYDinVtB5/dMSa5f2TAII9rKEU+A8fct5rMy1dFo00ux5DLjpWA0E39Y+biri8 ZW3xKJIYl9SDgbgmRAo= =6doF -----END PGP SIGNATURE----- --Sig_/1vkIXg4msSQ2yfcXberrHK_--