From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id C6C8B13824A for ; Sat, 7 May 2016 21:49:15 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 5FC26E085C; Sat, 7 May 2016 21:49:06 +0000 (UTC) Received: from plane.gmane.org (plane.gmane.org [80.91.229.3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 48FADE07F2 for ; Sat, 7 May 2016 21:49:04 +0000 (UTC) Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1azA5n-0008R7-Rw for gentoo-dev@lists.gentoo.org; Sat, 07 May 2016 23:48:55 +0200 Received: from 71-17-69-121.yktn.hsdb.sasknet.sk.ca ([71.17.69.121]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 07 May 2016 23:48:55 +0200 Received: from rhill by 71-17-69-121.yktn.hsdb.sasknet.sk.ca with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 07 May 2016 23:48:55 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: gentoo-dev@lists.gentoo.org From: Ryan Hill Subject: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/ Date: Sat, 7 May 2016 15:48:06 -0600 Organization: Gentoo Message-ID: <20160507154806.36e78548@tundra.gateway.pace.com> References: <1462655928.66afcab271f65b97330e610040ad3acc1b812a03.hd_brummy@gentoo> <20160507232558.1995dff5.mgorny@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/ONL4ebOj/1tI_F43zM59ea="; protocol="application/pgp-signature" X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 71-17-69-121.yktn.hsdb.sasknet.sk.ca X-Newsreader: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) X-Archives-Salt: 79beee85-2cb4-4906-83d6-759387a0de7d X-Archives-Hash: 980146f4da09946ff18d0e3c297043e9 --Sig_/ONL4ebOj/1tI_F43zM59ea= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sat, 7 May 2016 23:25:58 +0200 Micha=C5=82 G=C3=B3rny wrote: > On Sat, 7 May 2016 21:19:31 +0000 (UTC) > "Joerg Bornkessel" wrote: >=20 > > commit: 66afcab271f65b97330e610040ad3acc1b812a03 > > Author: Joerg Bornkessel gentoo org> > > AuthorDate: Sat May 7 21:18:48 2016 +0000 > > Commit: Joerg Bornkessel gentoo org> > > CommitDate: Sat May 7 21:18:48 2016 +0000 > > URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3D66af= cab2 > >=20 > > fixed einstall vs. emake install for eapi=3D6 > >=20 > > eclass/vdr-plugin-2.eclass | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > >=20 > > diff --git a/eclass/vdr-plugin-2.eclass b/eclass/vdr-plugin-2.eclass > > index ae09a34..65f1409 100644 > > --- a/eclass/vdr-plugin-2.eclass > > +++ b/eclass/vdr-plugin-2.eclass > > @@ -571,7 +571,11 @@ vdr-plugin-2_src_install() { > > local SOFILE_STRING=3D$(grep SOFILE Makefile) > > if [[ -n ${SOFILE_STRING} ]]; then > > BUILD_TARGETS=3D${BUILD_TARGETS:-${VDRPLUGIN_MAKE_TARGET:-install }} > > - einstall ${BUILD_PARAMS} \ > > + if [[ ${EAPI} =3D=3D 6 ]]; then > > + emake install ${BUILD_PARAMS} \ > > + else > > + einstall ${BUILD_PARAMS} \ > > + fi > > ${BUILD_TARGETS} \ > > TMPDIR=3D"${T}" \ > > DESTDIR=3D"${D}" \ > > =20 >=20 > Do you seriously expect this code to work? How about testing? Or > reading diffs before committing? I reverted this commit since it broke sourcing any ebuild inheriting the ec= lass. I'm going to assume this commit was made by accident, since any dev that wo= uld commit code to an eclass without testing that it works, or even that it's _valid bash_, would not continue to have unsupervised commit rights for very long. --=20 --Sig_/ONL4ebOj/1tI_F43zM59ea= Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.1 iQJ8BAEBCgBmBQJXLmKWXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRGMTVFMEI4RURDMzk0QkIxMjI1NjRBMUI1 MUM1NjY5NEIxMDBDRjZFAAoJEFHFZpSxAM9uL6MQAInR2lrqrJDbqx75oP5Z0osZ BYdupsmLh3JrhidVQaOA6p+npKmM9CGWjA8G+LsbLP7+6RMUJOg9jtyjaYuqMo4X 5+rRYQrLRkbcYAmExhkOCLUR2toAMGDQZtY9oVXPn5QfviInz5YeCi+i+NyDUmUI 4UrOB3q8CNhSI/6zYO5OOXsi7agIhXZFW4CcEAgo6GEl8/eaiglTDuYJTJQ3slPw zopyfwWi51vcYrvFZSOMbcV2dJnniNmmFtEA49lA9/j6HpxICL/s/R0T25omprqH NAb3oafvWd0/sLhTRTzBwC4LBKNCh/mUw5DapcwYvXeiLMsGkhT9iRn7Ob54bBwK diJevO4vKko+h2XBitIOlcKO+QbS7wyCiMQf1Gz5DGfl2r2nSGM2MxmoiOE3Ynr/ QqkjWj4w9fumi83hYrdJg/p4jZNNW3jaP35t+wqZk6iE8StV7CDVOSeREr2mVtps Jz8g9ujPkViFDY3hwPRYt9oVmWRK9SQh77qEvalsKO2JqhtylfH7CKOG6Ar1ZrIi tDBAcbYT6TrcePOyexwGIM4bJV92nECy1BUrXja8xHSuF+8KfH7f1nI/EMAZdVTt qzjnuNtocajRiB37ejhzk0aZribnYVI8WW36ie6dwQhFxehEsMs0g5QVd/waZTho yrHuCzuVSvH4zBjxyUJs =iNZZ -----END PGP SIGNATURE----- --Sig_/ONL4ebOj/1tI_F43zM59ea=--