From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 08C7F1381F4 for ; Sat, 23 Apr 2016 06:39:27 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id B9A2421C055; Sat, 23 Apr 2016 06:39:19 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id A1BC521C008 for ; Sat, 23 Apr 2016 06:39:18 +0000 (UTC) Received: from vapier.lan (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id 82685340C21; Sat, 23 Apr 2016 06:39:17 +0000 (UTC) Date: Sat, 23 Apr 2016 02:39:16 -0400 From: Mike Frysinger To: Leno Hou Cc: alex_y_xu@yahoo.ca, gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev][PATCH v1 ] sys-fs/hfsplusutils with gcc-5: blockiter.c:148:8: error: redefinition of blockiter_curr #580620 Message-ID: <20160423063916.GK5369@vapier.lan> Mail-Followup-To: Leno Hou , alex_y_xu@yahoo.ca, gentoo-dev@lists.gentoo.org References: <1461311849-25782-1-git-send-email-lenohou@gmail.com> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="moVvgYyABQIV3LC2" Content-Disposition: inline In-Reply-To: <1461311849-25782-1-git-send-email-lenohou@gmail.com> X-Archives-Salt: f029872c-ceeb-4e59-81ad-b181353919a4 X-Archives-Hash: 92cc1612ac3f5a55577f5826ed09e3c1 --moVvgYyABQIV3LC2 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On 22 Apr 2016 03:57, Leno Hou wrote: > +-extern inline UInt32 blockiter_curr(blockiter *b) > +-{ > +- return b->e->start_block + b->block; > +-} > +- > +- > ++extern inline UInt32 blockiter_curr(blockiter *b); i don't think that's how you want to handle extern inline. it doesn't make sense when it's declared this way as there is no actual body for gcc to optimisitcally inline. instead, we should go with what Ubuntu/Debian have: use the -fgnu89-inline flag to build since those are the semantics this code expects. i've pushed that fix now. -mike --moVvgYyABQIV3LC2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXGxiUAAoJEEFjO5/oN/WB/HEQAMr7X6OxrqEpTnIAGnXSyoUe Oqw78IceRdXZU0Y0q4pGl+ITKkQrJeArUtS0z9Vn6yvno8ESMY3F107iGPTroxRv IMWJTmnzfej5V/T2hlwP3vG3oLo9RoCEhY5SK2C0np36Rw8bIHg6Nr7g6fI6jKMi vwYSs3t9zTHn6ZYtmtb6rqTvEoGJa0iI5YG7lq5ng9ihyldQYYPC+qsOD9/h4ExK cz1017DdmWLUHyX/3muDk1vcDPMWy3v+JvejXntkZtXwoj5Mamt0hHb1C7MljbDL 6IkFamcg0hiLMSYmpNyMBSVG8OWaRcZWYoz5vwmIqK1SNvxZ79jve0Zi/rQxDesO +eIk7D6H1Xs6b56JtSY7BBgdpQt0HaEWxFusWUMBzh0zo79rfzPITz91V/jwF84j 88CBJotM+1TXJd1Mc5fw/KUPvwtpiHqzW72UAeab0eQUX0sg43unUZeLSZDqc9kx HqY9dmFLwPYObD4bnYbw95ZN1HeRzvqJhkTeTgYBhxVp/sIKcaBPDB0vobRAq8xj Z+rqIYTSZSPEQ6iz+wfxlTTD25MuMqH650bNQal7oKOnECXeEeR+lFe2XNLDtQwR cK8TetsBrzLdBxl+Fk5mLhuBzh+t29lK9i0twerY4CNL6Fb0crTaFC52TEbA1DEu fRDPq3JPqLjfdAFiGIit =Pxwx -----END PGP SIGNATURE----- --moVvgYyABQIV3LC2--