From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 9951C1388BF for ; Fri, 8 Jan 2016 05:15:28 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id D92B121C014; Fri, 8 Jan 2016 05:15:12 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id F1B1321C00E for ; Fri, 8 Jan 2016 05:15:11 +0000 (UTC) Received: from pomiot (d202-252.icpnet.pl [109.173.202.252]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id B3D7A340A60; Fri, 8 Jan 2016 05:15:10 +0000 (UTC) Date: Fri, 8 Jan 2016 06:15:04 +0100 From: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH 00/15] scons-utils.eclass: EAPI 6, better docs and cleanup Message-ID: <20160108061505.04e75f36.mgorny@gentoo.org> In-Reply-To: <1451666481-22145-1-git-send-email-mgorny@gentoo.org> References: <1451666481-22145-1-git-send-email-mgorny@gentoo.org> Organization: Gentoo X-Mailer: Claws Mail 3.13.1 (GTK+ 2.24.29; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/Pclwo_55X5k3Wc01UZi417G"; protocol="application/pgp-signature" X-Archives-Salt: e2f5df2a-0ae9-4f26-b77a-08f55e510887 X-Archives-Hash: 2cbb35349c635339204fcf7e08fa0fd4 --Sig_/Pclwo_55X5k3Wc01UZi417G Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, 1 Jan 2016 17:41:06 +0100 Micha=C5=82 G=C3=B3rny wrote: > Hello, everyone. >=20 > Here's a bunch of scons-utils.eclass patches for review. This includes > EAPI 6 support with some API changes, MAKEOPTS parsing cleanup > and improved documentation. >=20 > Fighting dev-db/mongodb lately, I've decided to explain a few common > issues with SCons in the eclass. This will hopefully help developers > noticing common QA issues like complete disrespect of CC, CXX or PATH, > turning distcc setup into a dumb OOM-killer. >=20 > EAPI 6 simplifies the eclass API and makes it more explicit. >=20 > The confusing myesconsargs variable is no longer used in EAPI 6 and all > custom arguments need to passed explicitly to each escons call. This > makes it more consistent with emake. And like emake, escons starts truly > respecting nonfatal in EAPI 6. >=20 > The use_scons function is completely banned in EAPI 6. Already since > EAPI 5, usex was a cleaner alternative. As a result, USE_SCONS_TRUE > and USE_SCONS_FALSE variables are no longer used (not that anybody used > them anyway). >=20 > Finally, the MAKEOPTS parsing and transforming has been improved a bit. > It has been redesigned so that the caching mechanism could actually > work. --jobs lacking argument are now replaced by no-of-cpus+1 > (obtained using nproc or python) rather than random, fixed number. >=20 > Please review. >=20 >=20 > Micha=C5=82 G=C3=B3rny (15): > scons-utils.eclass: Modernize the example not to rely on myescons... > scons-utils.eclass: Modernize the example to use usex > scons-utils.eclass: Describe common issues with scons > scons-utils.eclass: escons doc, 'die' does not respect nonfatal > scons-utils.eclass: escons, invert EAPI check to cover future EAPIs > scons-utils.eclass: escons, respect nonfatal in EAPI 6 > scons-utils.eclass: Deprecate myesconsargs, and kill it in EAPI 6 > scons-utils.eclass: Deprecate use_scons, ban it in EAPI 6 > scons-utils.eclass: tests, be more verbose on tests being performed > scons-utils.eclass: scons_clean_makeopts, mark internal > scons-utils.eclass: _scons_clean_makeopts, fix result caching > scons-utils.eclass: _scons_clean_makeopts, stop exporting cache vars > scons-utils.eclass: _scons_clean_makeopts, clean up and simplify > scons-utils.eclass: Use nproc when --jobs is used without an argument > scons-utils.eclass: Enable EAPI 6 >=20 > eclass/scons-utils.eclass | 138 +++++++++++++++++++++++++++++++++-----= ------ > eclass/tests/scons-utils.sh | 21 ++++--- > 2 files changed, 114 insertions(+), 45 deletions(-) Merged. --=20 Best regards, Micha=C5=82 G=C3=B3rny --Sig_/Pclwo_55X5k3Wc01UZi417G Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJWj0XZXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ2REJCMDdDQzRGMERBRDA2RUEwQUZFNDFC MDdBMUFFQUVGQjQ0NjRFAAoJELB6GurvtEZO8m0QAJJ5GmziqrMg0v5GcNP3phTA c7OL5zk5fch6DsfgsTsMagL9WaW0N/d9EiS+F9KtrJMnrwSod3wrFP3I+Xl+2jDI dM1pT4osUBWrmSZIlDzYMsVqidPa6t+a5/zks51pSJLCmqddu4HTi8T6ZPa/jsUZ LbAzTf+Vf5wGqlrazu2Hps9/zvHHOZ3rBC+notud/sLhIIqWV52glv5khI0v5RV5 PeG7ZF0tKkluPMj0WqsJd3OP/UYedqifp4omTI7RHHaVLYzJIDpTCrkNMViz4EsM JOfnHGo7x+ooXKYxdR1Op9cUs7QqZq1HtlExmqXx+weVjBQvC1DwVhZs+s6jJf5J bNas+4Kb1VoddfYbUoa3+ARr2hEEvYRaiL/vNvA+SQZRPx0xGzxQXClboVjzUud0 3KU6C7eact1X+bM6CvNCX02eAu9Y5XpBpcpTwqJW+404XWFdO2zTw7R9zxBucDhb B0Bbr6ENnSLFBu3mShkWhnGTMUeCCTZWk3/D9BFVMP/pFhMXHbFtRROIg0zZRz6T Qate1QgeMc3Iye8kwyg/7VFJ6nSQKV5uMCw4seiAiHA0tHVl5jSs8Y3ysMpdF39H 6y4YckGGBnjEM4ISAg2ZlW1i/q1ErCYGfRtCWV91JUlW3+7csp+PLLi0MTIbyaWe JXHfMHL0Xon0/zHLuwz+ =OtSj -----END PGP SIGNATURE----- --Sig_/Pclwo_55X5k3Wc01UZi417G--