From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 573CC1384B4 for ; Mon, 4 Jan 2016 15:45:52 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 4149821C005; Mon, 4 Jan 2016 15:45:44 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 421A8E0798 for ; Mon, 4 Jan 2016 15:45:42 +0000 (UTC) Received: from localhost (dra13-4-78-234-166-189.fbx.proxad.net [78.234.166.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: aballier) by smtp.gentoo.org (Postfix) with ESMTPSA id BE1DE34069F for ; Mon, 4 Jan 2016 15:45:40 +0000 (UTC) Date: Mon, 4 Jan 2016 16:45:32 +0100 From: Alexis Ballier To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Eclass assisted multilib dependent cache updates Message-ID: <20160104164532.4f52654a@gentoo.org> In-Reply-To: <1451750071.31635.9.camel@gentoo.org> References: <1451750071.31635.9.camel@gentoo.org> Organization: Gentoo X-Mailer: Claws Mail 3.13.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Archives-Salt: 65279907-027e-479a-a3fa-7d572dd52170 X-Archives-Hash: 0e282deedd50d83a3c0c5a6a56f80df0 On Sat, 02 Jan 2016 16:54:31 +0100 Gilles Dartiguelongue wrote: > Hello all, > > while working on bug #518422, I found out that while eclass calls the > relevant cache updates it has no idea whether or not it is called in a > multilib context or not. Hmm... what's the problem here ? What you seem to call "not a multilib context" is a multilib build with only one ABI. That's one of the points of inheriting the multilib eclasses. > Imho, this leads to avoidable human errors where one thinks eclass > will take care of lib dependent caches, which it does, but not for all > enabled ABIs which could lead to reduced functionality for non-native > ABIs. > > While it seems reasonable to call multilib_foreach_abi > gnome2_pkg_postinst for multilib enabled ebuilds, it is still not > ideal as it will call a lot of functions for no good reason. On the > other hand, checking environment variable set by multilib eclasses > does not seem like a robust solution. > > Is there any reasonable way to make phase functions aware of if they > are running in a multilib enabled ebuild to adjust their behavior ? Per the above, 'multilib_foreach_abi' seems just fine. Is there a real problem with it?