From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 5E11C1384B4 for ; Fri, 1 Jan 2016 17:15:46 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 652D121C027; Fri, 1 Jan 2016 17:15:38 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 5E94421C002 for ; Fri, 1 Jan 2016 17:15:37 +0000 (UTC) Received: from pomiot (d202-251.icpnet.pl [109.173.202.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 8AC2A340A9F; Fri, 1 Jan 2016 17:15:35 +0000 (UTC) Date: Fri, 1 Jan 2016 18:15:25 +0100 From: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= To: Michael Palimaka Cc: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: [PATCH 01/15] scons-utils.eclass: Modernize the example not to rely on myescons... Message-ID: <20160101181525.4aee6ea0.mgorny@gentoo.org> In-Reply-To: References: <1451666481-22145-1-git-send-email-mgorny@gentoo.org> <1451666481-22145-2-git-send-email-mgorny@gentoo.org> Organization: Gentoo X-Mailer: Claws Mail 3.13.1 (GTK+ 2.24.29; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/uxbcoB9B+YlhCPxN.yOm8gL"; protocol="application/pgp-signature" X-Archives-Salt: d39da88b-5996-4f98-b5d0-9a12233d7116 X-Archives-Hash: 1b778d309cd5e5f04dc2497eacbcd19b --Sig_/uxbcoB9B+YlhCPxN.yOm8gL Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sat, 2 Jan 2016 03:57:59 +1100 Michael Palimaka wrote: > On 02/01/16 03:41, Micha=C5=82 G=C3=B3rny wrote: > > --- > > eclass/scons-utils.eclass | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > >=20 > > diff --git a/eclass/scons-utils.eclass b/eclass/scons-utils.eclass > > index a2a6884..e1b3a1b6 100644 > > --- a/eclass/scons-utils.eclass > > +++ b/eclass/scons-utils.eclass > > @@ -1,4 +1,4 @@ > > -# Copyright 1999-2012 Gentoo Foundation > > +# Copyright 1999-2015 Gentoo Foundation > > # Distributed under the terms of the GNU General Public License v2 > > # $Id$ > > =20 > > @@ -17,19 +17,19 @@ > > # EAPI=3D4 > > # > > # src_configure() { > > -# myesconsargs=3D( > > +# MYSCONS=3D( > > # CC=3D"$(tc-getCC)" > > # $(use_scons nls ENABLE_NLS) > > # ) > > # } > > # > > # src_compile() { > > -# escons > > +# escons "${MYSCONS[@]}" > > # } > > # > > # src_install() { > > # # note: this can be DESTDIR, INSTALL_ROOT, ... depending on package > > -# escons DESTDIR=3D"${D}" install > > +# escons "${MYSCONS[@]}" DESTDIR=3D"${D}" install > > # } > > # @CODE > > =20 > > =20 >=20 > What is the benefit of MYSCONS vs myesconsargs? The latter seems to be > more consistent with other eclasses (mycmakeargs, myqmakeargs, ...) It's shorter and follows the convention of keeping global variables uppercase. Consistency with bad example set by one eclass is not a good argument. In fact, cmake-utils sets a very bad example of enforcing declarative model over function-oriented ebuilds which results in really absurd src_configure() implementations. src_configure() { local mycmakeargs=3D( ... ) cmake-utils_src_configure } vs src_configure() { local myconf=3D( ... ) ecmake "${myconf[@]}" } --=20 Best regards, Micha=C5=82 G=C3=B3rny --Sig_/uxbcoB9B+YlhCPxN.yOm8gL Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJWhrQuXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ2REJCMDdDQzRGMERBRDA2RUEwQUZFNDFC MDdBMUFFQUVGQjQ0NjRFAAoJELB6GurvtEZOrWwP/AruKXv8mT+0S0DNSqPkzYFz hMCZWSNP8iXGAcqtPHLSsSDJs6VcG3UXzB8LhjfM4UeIdtwC6jD/lY0j1CVH4VyF fGCQD45Wk/+YpqpL9nQrQw4bAofz8q3eLTT4A0ZiA91nP6BU1gnqzo73Nu0ESgfH kQByvqovri+0UKgpQCHG0UW+NT1PXlavY6FFhlSOyBiSXotPWARtww45vN8JcaOP faqtPrdrlkx8StRFnd6m/O6t6rjklQ3ji15ImS1OT5G0XlNR6V+PmI0pusyEm5j0 t4/u+Y5KepXUosKwYCbF1gWq+g1B9WA1hywlYBdqm0Qt3hgtbOusrB3xbgW1WTRN /YqWDopSnws/guCL0dnq7dd4pW3PsQT0qffu+BcrJ4PdYtvJN/3aVG05AgRrtH17 mDu00aN7VkRXm216+jcLT/b3qSmcSwKNhh4mxsno8TsmUIsrnA5CMh2SYFzIvbsj f5ZFVv+X4lrF4SuyFOhxMhU0XwdsOAmpmmYJWrOdi8v3+8KmEptsLzsWndA1SrER brpA1bdBmkO1U2eYhq+lDKdWQim52R21GlXea1U/22eIMD4hOfAi26BVqpfmvXjo ClxIgGcbpo0rUyYZyDKaYC3ItlZObQVYsyjZnTH9Xv5Qae9f4q2wdbtz6HHkgIeA YxSmAccHEvnZbsOES+9L =Ledf -----END PGP SIGNATURE----- --Sig_/uxbcoB9B+YlhCPxN.yOm8gL--