From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 114601384B4 for ; Tue, 29 Dec 2015 17:40:37 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 2FC97E0825; Tue, 29 Dec 2015 17:40:28 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 509B6E080E for ; Tue, 29 Dec 2015 17:40:27 +0000 (UTC) Received: from pomiot (d202-251.icpnet.pl [109.173.202.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 163FB340554; Tue, 29 Dec 2015 17:40:24 +0000 (UTC) Date: Tue, 29 Dec 2015 18:40:13 +0100 From: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= To: Peter Stuge Cc: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH 0/5] python-r1 suite: python_gen_impl_dep() function Message-ID: <20151229184013.694e8a1b.mgorny@gentoo.org> In-Reply-To: <20151224153032.28420.qmail@stuge.se> References: <1450889080-1920-1-git-send-email-mgorny@gentoo.org> <20151224153032.28420.qmail@stuge.se> Organization: Gentoo X-Mailer: Claws Mail 3.13.1 (GTK+ 2.24.29; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/ca1nnOVH786=tGL/_AEPPBP"; protocol="application/pgp-signature" X-Archives-Salt: c7a3831a-6ee6-4629-812a-2b9091d547ee X-Archives-Hash: da7ca5ef912b35184ec55d391fc6a41e --Sig_/ca1nnOVH786=tGL/_AEPPBP Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, 24 Dec 2015 16:30:32 +0100 Peter Stuge wrote: > Micha=C5=82 G=C3=B3rny wrote: > > Please review the patches sent in reply. =20 >=20 > The changes look good to me, but maybe the function should have > 'use' in its name; it's not obvious that the parameter is about > USE as opposed to PN. Any specific suggestions? --=20 Best regards, Micha=C5=82 G=C3=B3rny --Sig_/ca1nnOVH786=tGL/_AEPPBP Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJWgsV9XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ2REJCMDdDQzRGMERBRDA2RUEwQUZFNDFC MDdBMUFFQUVGQjQ0NjRFAAoJELB6GurvtEZOV54QAJU7MCJ1yllrcQwvNWjOVjxA ePFDzMnJfj2U+i4JeKHPdNsTPQejbrcALvK4PgwKpi9rc1QrguSLh8F4cNvlOTjc OQTYV677uAypqQ2yicGZ+UrBafvP8vzEZDZuxl9rTN9JdVjMAVWLcSkZPz/kzd9Y ixyU0zAIjxXD3LMdw+JTMx51amLrXka52n6K6rdwe4dypKaKsy16TZQAmi9ddPVD TVbacqssARuzkkaDIoZx1SFHLxqxQMHydxnrkivADFqTTv5hJVKVtVAnFSpE9czz tIKZIkJSzawi3Ngv4n5QoeCKJ6FTciRG4p1EgMJXHDy/JWSflryw0OZynQAqaqEy Nvc5h2QlzKc/+i6HO/rkdQmZvxoz1tV7WTkkjx5TsC9y4fEJoN84c+Gy0hri+pwG +YvRmJkx8dixCKqD2gRNUCpG3xnAAu7AI9t3n1AD39xQPSM5c4A9PFhxh+J3ItQp To+4R8kV9kjnzQEi7z+vRNR9NAvPfftsy19w+JM7HGArNpU8o3uJvyCI1f+VmbFk fPQ/3o0G/PEUlLyMVT5yaIgUshBLSOyhHaOKlaVdlIulnimygZ7housV210wMVT9 pAUs3FiEGJceQ8KjCRj+Rv26+ZBFgaxZCRn8Vtw2ff+8E1a8OvFPqoABxQ2//BB0 TA/+Tt2DlmcSAEwaNSij =YDQ7 -----END PGP SIGNATURE----- --Sig_/ca1nnOVH786=tGL/_AEPPBP--