From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 6DBBD1384B4 for ; Mon, 28 Dec 2015 13:58:41 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 3E9D621C042; Mon, 28 Dec 2015 13:58:33 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 5EF6C21C00B for ; Mon, 28 Dec 2015 13:58:32 +0000 (UTC) Received: from localhost (unknown [91.246.102.95]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: bircoph) by smtp.gentoo.org (Postfix) with ESMTPSA id 0C156340A9D for ; Mon, 28 Dec 2015 13:58:30 +0000 (UTC) Date: Mon, 28 Dec 2015 16:58:26 +0300 From: Andrew Savchenko To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH 5/9] check-reqs.eclass: Replace obsolete df option -m with -B ### Message-Id: <20151228165826.3117022fcf5ed9f66d2089f6@gentoo.org> In-Reply-To: <1451292235-25265-6-git-send-email-jlec@gentoo.org> References: <1451292235-25265-1-git-send-email-jlec@gentoo.org> <1451292235-25265-6-git-send-email-jlec@gentoo.org> X-Mailer: Sylpheed 3.4.3 (GTK+ 2.24.20; i686-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg="PGP-SHA512"; boundary="Signature=_Mon__28_Dec_2015_16_58_26_+0300_Nb4_24vHpRVc_QPH" X-Archives-Salt: a5c63c6a-426a-401a-a059-32b28306c1fa X-Archives-Hash: c392d845c26e6b94bb15b9025a15f1e3 --Signature=_Mon__28_Dec_2015_16_58_26_+0300_Nb4_24vHpRVc_QPH Content-Type: text/plain; charset=US-ASCII Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Mon, 28 Dec 2015 09:43:51 +0100 Justin Lecher wrote: > Signed-off-by: Justin Lecher > --- > eclass/check-reqs.eclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/eclass/check-reqs.eclass b/eclass/check-reqs.eclass > index 138bfec..a32f8f8 100644 > --- a/eclass/check-reqs.eclass > +++ b/eclass/check-reqs.eclass > @@ -306,7 +306,7 @@ check-reqs_disk() { > ${size} \ > "disk space at \"${path}\"" > =20 > - space_megs=3D$(df -Pm "${1}" 2>/dev/null | awk 'FNR =3D=3D 2 {print $4}= ') > + space_megs=3D$(df -P -B 1048576 "${1}" 2>/dev/null | awk 'FNR =3D=3D 2 = {print $4}') Why not "-BM"? IMHO, this will be more readable, though, of course, both arguments are semantically correct. Best regards, Andrew Savchenko --Signature=_Mon__28_Dec_2015_16_58_26_+0300_Nb4_24vHpRVc_QPH Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJWgUACAAoJEPZTWjO6HuSNg7QP/RXbtchv6MElvMg33HIQ1GPH Zb/I17e+ULavyAj8aIKNtHdtxi6hci54Ybtdpx8QCj4awAM+yotyQuBBUlSGr4re +uvRm/geR2lYGnNyVWWDSHU2P88+HrOco8lKrY50RqEfPhepbT4NvVZQ0+7qmF/2 4qYZhkjm1HHTgC5JTxONBQTLaoWsgxsPdNV83leb584tY3oHxon7h6QpUk4NmFBu 9HDGXLZ4VckgfPicZ8CN7Xj0NgX/BxR05LeKp/rt3FoG37XjGM7bFiR2VxTBV9HM ZfmrlQIZBfHyhnhn7fPcAiXywoA5Oe95NMCqjUIn6J2Kh0116UBY3KOqhSaCBuiW 0R2lxLMBMYM9zTFU7FG0Zs2wW8YIaTH+0n1ugx9UUufrLs2mZzr9eGOiDz8QUzNT z1QBuNdiJuAv+pNzi4QpcGKoVj3Or9Zvg4qMkAeaF+T3kr4LTsJ2VKq6tw0aI7fH WMVn/JYkW+SeNbo/4JYqrj/vhrSiETwGqJ7B13GTu1vMtiBeeOE3UbBw0PNWQKXC q3zcoYrAYjhxBnn+rsJRkec0bfsosh9M7L2TBhXN1wvmdYqokng/wOkleNtvF/Cu wmBIBDNA5kALhMbb5nFEqGRzWRYykg2Ua5/g99Cao7NmNQfRPq6xX/zbg1BXM6rd O6S4wXuSRoIRria8w4Wu =tWTC -----END PGP SIGNATURE----- --Signature=_Mon__28_Dec_2015_16_58_26_+0300_Nb4_24vHpRVc_QPH--