From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 50C6E1384B4 for ; Sat, 26 Dec 2015 11:53:36 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id EBBEFE07F9; Sat, 26 Dec 2015 11:53:28 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 1A308E07E2 for ; Sat, 26 Dec 2015 11:53:28 +0000 (UTC) Received: from wim.fritz.box (unknown [IPv6:2001:984:fcd5:1:9f7a:61db:6e7d:c0f5]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: jer) by smtp.gentoo.org (Postfix) with ESMTPSA id 58C553402A2; Sat, 26 Dec 2015 11:53:26 +0000 (UTC) Date: Sat, 26 Dec 2015 12:53:20 +0100 From: Jeroen Roovers To: dilfridge@gentoo.org Cc: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH 10/15] perl-module.eclass: Rename SRC_TEST to DIST_TEST in EAPI=6 and default to "do parallel" Message-ID: <20151226125320.65402f14@wim.fritz.box> In-Reply-To: <1449867791-30513-10-git-send-email-dilfridge@gentoo.org> References: <201512112201.15354.dilfridge@gentoo.org> <1449867791-30513-1-git-send-email-dilfridge@gentoo.org> <1449867791-30513-10-git-send-email-dilfridge@gentoo.org> Organization: Gentoo Foundation X-Mailer: Claws Mail 3.13.1 (GTK+ 2.24.28; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Archives-Salt: 1647d641-5834-4c82-81dd-7aae31a527bb X-Archives-Hash: d10efcf2c327617b54e41b21e92f0385 On Fri, 11 Dec 2015 22:03:06 +0100 dilfridge@gentoo.org wrote: > From: "Andreas K. Huettel (dilfridge)" > > --- > eclass/perl-module.eclass | 40 > +++++++++++++++++++++++----------------- 1 file changed, 23 > insertions(+), 17 deletions(-) > > diff --git a/eclass/perl-module.eclass b/eclass/perl-module.eclass > index efcc47c..0d428d2 100644 > --- a/eclass/perl-module.eclass > +++ b/eclass/perl-module.eclass > @@ -154,6 +154,8 @@ if [[ ${EAPI:-0} = 5 ]] ; then > SRC_URI="mirror://cpan/authors/id/${MODULE_AUTHOR:0:1}/${MODULE_AUTHOR:0:2}/${MODULE_AUTHOR}/${MODULE_SECTION:+${MODULE_SECTION}/}${MODULE_A}" > [[ -z "${HOMEPAGE}" ]] && \ > HOMEPAGE="http://search.cpan.org/dist/${MODULE_NAME}/" > + > + SRC_TEST="skip" > else > DIST_NAME=${DIST_NAME:-${PN}} > DIST_P=${DIST_NAME}-${DIST_VERSION:-${PV}} > @@ -168,7 +170,6 @@ else > fi You're disabling src_test() by default in any ebuild that happens to inherit perl-module. Everyone who wants a way around that has to set STUPID_VARIABLE now. Why? jer