public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Jeroen Roovers <jer@gentoo.org>
To: dilfridge@gentoo.org
Cc: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH 10/15] perl-module.eclass: Rename SRC_TEST to DIST_TEST in EAPI=6 and default to "do parallel"
Date: Sat, 26 Dec 2015 12:53:20 +0100	[thread overview]
Message-ID: <20151226125320.65402f14@wim.fritz.box> (raw)
In-Reply-To: <1449867791-30513-10-git-send-email-dilfridge@gentoo.org>

On Fri, 11 Dec 2015 22:03:06 +0100
dilfridge@gentoo.org wrote:

> From: "Andreas K. Huettel (dilfridge)" <dilfridge@gentoo.org>
> 
> ---
>  eclass/perl-module.eclass | 40
> +++++++++++++++++++++++----------------- 1 file changed, 23
> insertions(+), 17 deletions(-)
> 
> diff --git a/eclass/perl-module.eclass b/eclass/perl-module.eclass
> index efcc47c..0d428d2 100644
> --- a/eclass/perl-module.eclass
> +++ b/eclass/perl-module.eclass
> @@ -154,6 +154,8 @@ if [[ ${EAPI:-0} = 5 ]] ; then
>  		SRC_URI="mirror://cpan/authors/id/${MODULE_AUTHOR:0:1}/${MODULE_AUTHOR:0:2}/${MODULE_AUTHOR}/${MODULE_SECTION:+${MODULE_SECTION}/}${MODULE_A}"
>  	[[ -z "${HOMEPAGE}" ]] && \
>  		HOMEPAGE="http://search.cpan.org/dist/${MODULE_NAME}/"
> +
> +	SRC_TEST="skip"
>  else
>  	DIST_NAME=${DIST_NAME:-${PN}}
>  	DIST_P=${DIST_NAME}-${DIST_VERSION:-${PV}}
> @@ -168,7 +170,6 @@ else
>  fi

You're disabling src_test() by default in any ebuild that happens to
inherit perl-module. Everyone who wants a way around that has to set
STUPID_VARIABLE now. Why?


     jer


  parent reply	other threads:[~2015-12-26 11:53 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-11 21:01 [gentoo-dev] perl-module.eclass EAPI=6 support Andreas K. Huettel
2015-12-11 21:02 ` [gentoo-dev] [PATCH 01/15] perl-module.eclass: Allow EAPI=6, ban PERL_EXPORT_PHASE_FUNCTIONS there, simplify perl dependency dilfridge
2015-12-11 21:02   ` [gentoo-dev] [PATCH 02/15] perl-module.eclass: Remove references to perlinfo_done dilfridge
2015-12-11 21:02   ` [gentoo-dev] [PATCH 03/15] perl-module.eclass: Just go ahead when calling configure twice in EAPI=6 dilfridge
2015-12-12 11:50     ` Michał Górny
2015-12-12 16:14       ` Andreas K. Huettel
2015-12-11 21:03   ` [gentoo-dev] [PATCH 04/15] perl-module.eclass: Use default unpacking from EAPI=6 on dilfridge
2015-12-11 23:40     ` Ulrich Mueller
2015-12-12 20:23       ` Andreas K. Huettel
2015-12-11 21:03   ` [gentoo-dev] [PATCH 05/15] perl-module.eclass: Use eapply from EAPI=6 on and always call eapply_user dilfridge
2015-12-12 11:54     ` Michał Górny
2015-12-12 20:23       ` Andreas K. Huettel
2015-12-11 21:03   ` [gentoo-dev] [PATCH 06/15] perl-module.eclass: Introduce MODULE_NAME and MODULE_P while still keeping existing weirdness compatible dilfridge
2015-12-12 11:57     ` Michał Górny
2015-12-11 21:03   ` [gentoo-dev] [PATCH 07/15] perl-module.eclass: Do not do any magic with MY_... variables in EAPI=6 anymore dilfridge
2015-12-12 11:59     ` Michał Górny
2015-12-12 20:26       ` Andreas K. Huettel
2015-12-11 21:03   ` [gentoo-dev] [PATCH 08/15] perl-module.eclass: Document variables available in EAPI=6 dilfridge
2015-12-11 21:03   ` [gentoo-dev] [PATCH 09/15] perl-module.eclass: Use DIST_ prefix instead of MODULE_ prefix in EAPI=6 for control variables dilfridge
2015-12-12  9:15     ` [gentoo-dev] " Duncan
2015-12-12 20:29       ` Andreas K. Huettel
2015-12-13  6:09         ` Duncan
2015-12-12 12:01     ` [gentoo-dev] " Michał Górny
2015-12-12 20:31       ` Andreas K. Huettel
2015-12-11 21:03   ` [gentoo-dev] [PATCH 10/15] perl-module.eclass: Rename SRC_TEST to DIST_TEST in EAPI=6 and default to "do parallel" dilfridge
2015-12-12 12:03     ` Michał Górny
2015-12-12 20:41       ` Andreas K. Huettel
2015-12-13  2:23         ` Kent Fredric
2015-12-26 11:53     ` Jeroen Roovers [this message]
2015-12-27 11:37       ` Andreas K. Huettel
2015-12-11 21:03   ` [gentoo-dev] [PATCH 11/15] perl-module.eclass: Introduce DIST_TEST_OVERRIDE in EAPI=6 dilfridge
2015-12-12 12:05     ` Michał Górny
2015-12-12 12:06       ` Michał Górny
2015-12-12 16:13         ` Andreas K. Huettel
2015-12-11 21:03   ` [gentoo-dev] [PATCH 12/15] perl-module.eclass: Minor docu improvements dilfridge
2015-12-11 21:03   ` [gentoo-dev] [PATCH 13/15] perl-module.eclass: Make some former warnings fatal to get rid of PERLQAFATAL, eqawarn, and (in EAPI=6) eutils.eclass dilfridge
2015-12-11 21:03   ` [gentoo-dev] [PATCH 14/15] perl-module.eclass: Rewrite src_test for EAPI=6 dilfridge
2015-12-11 21:03   ` [gentoo-dev] [PATCH 15/15] dev-perl/CGI: Add EAPI=6 test ebuild dilfridge
2015-12-12 11:49   ` [gentoo-dev] [PATCH 01/15] perl-module.eclass: Allow EAPI=6, ban PERL_EXPORT_PHASE_FUNCTIONS there, simplify perl dependency Michał Górny
2015-12-12 20:22     ` Andreas K. Huettel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151226125320.65402f14@wim.fritz.box \
    --to=jer@gentoo.org \
    --cc=dilfridge@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox