From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 512131384B4 for ; Thu, 24 Dec 2015 15:30:46 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id A2D5121C084; Thu, 24 Dec 2015 15:30:36 +0000 (UTC) Received: from foo.stuge.se (foo.stuge.se [212.116.89.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 75CD521C029 for ; Thu, 24 Dec 2015 15:30:34 +0000 (UTC) Received: (qmail 28421 invoked by uid 501); 24 Dec 2015 15:30:32 -0000 Message-ID: <20151224153032.28420.qmail@stuge.se> Date: Thu, 24 Dec 2015 16:30:32 +0100 From: Peter Stuge To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH 0/5] python-r1 suite: python_gen_impl_dep() function Mail-Followup-To: gentoo-dev@lists.gentoo.org References: <1450889080-1920-1-git-send-email-mgorny@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1450889080-1920-1-git-send-email-mgorny@gentoo.org> X-Archives-Salt: f5ba3097-93d3-4d9f-bc1e-49a4a85604c8 X-Archives-Hash: d1a8981616dee9fb96ac2240dc7a0fa9 Michał Górny wrote: > Please review the patches sent in reply. The changes look good to me, but maybe the function should have 'use' in its name; it's not obvious that the parameter is about USE as opposed to PN. //Peter