public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Peter Stuge <peter@stuge.se>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH 0/5] python-r1 suite: python_gen_impl_dep() function
Date: Thu, 24 Dec 2015 16:30:32 +0100	[thread overview]
Message-ID: <20151224153032.28420.qmail@stuge.se> (raw)
In-Reply-To: <1450889080-1920-1-git-send-email-mgorny@gentoo.org>

Michał Górny wrote:
> Please review the patches sent in reply.

The changes look good to me, but maybe the function should have
'use' in its name; it's not obvious that the parameter is about
USE as opposed to PN.


//Peter


  parent reply	other threads:[~2015-12-24 15:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-23 16:44 [gentoo-dev] [PATCH 0/5] python-r1 suite: python_gen_impl_dep() function Michał Górny
2015-12-23 16:44 ` [gentoo-dev] [PATCH 1/5] python-r1.eclass: Introduce python_gen_impl_dep Michał Górny
2015-12-23 16:44 ` [gentoo-dev] [PATCH 2/5] python-single-r1.eclass: Add python_gen_impl_dep, alike in python-r1 Michał Górny
2015-12-23 16:44 ` [gentoo-dev] [PATCH 3/5] app-emulation/xen-tools: Make use of new python_gen_impl_dep function Michał Górny
2015-12-24 16:21   ` Doug Goldstein
2015-12-23 16:44 ` [gentoo-dev] [PATCH 4/5] dev-python/django: Make use of the " Michał Górny
2015-12-23 16:44 ` [gentoo-dev] [PATCH 5/5] sys-apps/portage: " Michał Górny
2015-12-24 15:30 ` Peter Stuge [this message]
2015-12-29 17:40   ` [gentoo-dev] [PATCH 0/5] python-r1 suite: python_gen_impl_dep() function Michał Górny
2015-12-31 14:52 ` Michał Górny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151224153032.28420.qmail@stuge.se \
    --to=peter@stuge.se \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox