From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 6F6011384B4 for ; Sat, 12 Dec 2015 20:22:18 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 1D4BC21C0A1; Sat, 12 Dec 2015 20:22:10 +0000 (UTC) Received: from mo4-p05-ob.smtp.rzone.de (mo4-p05-ob.smtp.rzone.de [81.169.146.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 0ABF421C064 for ; Sat, 12 Dec 2015 20:22:07 +0000 (UTC) X-RZG-AUTH: :IW0NeWCpcPchHrcnS4ebzBgQnKHTmUiSF2JlOcyy9p4roSnp5yQo4oJ5cg== X-RZG-CLASS-ID: mo05 Received: from pinacolada.localnet (88-133-183-17.hsi.glasfaser-ostbayern.de [88.133.183.17]) by smtp.strato.de (RZmta 37.14 AUTH) with ESMTPSA id n00381rBCKM5AFL (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Sat, 12 Dec 2015 21:22:05 +0100 (CET) From: "Andreas K. Huettel" To: =?utf-8?q?Micha=C5=82_G=C3=B3rny?= Subject: Re: [gentoo-dev] [PATCH 01/15] perl-module.eclass: Allow EAPI=6, ban PERL_EXPORT_PHASE_FUNCTIONS there, simplify perl dependency Date: Sat, 12 Dec 2015 21:22:00 +0100 User-Agent: KMail/1.13.7 (Linux/4.2.3; KDE/4.14.14; x86_64; ; ) Cc: gentoo-dev@lists.gentoo.org References: <201512112201.15354.dilfridge@gentoo.org> <1449867791-30513-1-git-send-email-dilfridge@gentoo.org> <4DE45668-E86E-4861-9F6A-16492D5813B3@gentoo.org> In-Reply-To: <4DE45668-E86E-4861-9F6A-16492D5813B3@gentoo.org> Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <201512122122.05156.dilfridge@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Archives-Salt: c12ad0dd-bbb6-4529-a055-4cda402e4d58 X-Archives-Hash: 14dbd27a0b590e77076c61471c47c69a -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Am Samstag, 12. Dezember 2015, 12:49:09 schrieb Michał Górny: > Dnia 11 grudnia 2015 22:02:57 CET, dilfridge@gentoo.org napisał(a): > >+ case "${PERL_EXPORT_PHASE_FUNCTIONS:-yes}" in > >+ yes) > >+ EXPORT_FUNCTIONS ${PERL_EXPF} > >+ ;; > >+ no) > >+ debug-print "PERL_EXPORT_PHASE_FUNCTIONS=no" > >+ ;; > >+ *) > >+ die "PERL_EXPORT_PHASE_FUNCTIONS=${PERL_EXPORT_PHASE_FUNCTIONS} is > >not supported by perl-module.eclass" > >+ ;; > >+ esac > > You could split this move, you know. Yeah but it's probably more useful to change behavior now and then keep it consistent for whole EAPI=6... > >+ case "${GENTOO_DEPEND_ON_PERL:-yes}" in > >+ yes) > >+ case "${GENTOO_DEPEND_ON_PERL_SUBSLOT:-yes}" in > >+ yes) > >+ DEPEND="dev-lang/perl:=" > >+ ;; > >+ *) > >+ DEPEND="dev-lang/perl" > >+ ;; > >+ esac > >+ RDEPEND="${DEPEND}" > >+ ;; > >+ esac > > Why don't you pack this stuff into a single trinary variable? Good idea. Let's kill GENTOO_DEPEND_ON_PERL_SUBSLOT (never liked it, too long variable name :) and instead provide support for GENTOO_DEPEND_ON_PERL=noslotop - -- Andreas K. Huettel Gentoo Linux developer dilfridge@gentoo.org http://www.akhuettel.de/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.1 iQJ8BAEBCgBmBQJWbIHoXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ0RkJDMzI0NjNBOTIwMDY5MTQ2NkMzNDBF MTM4NkZEN0VGNEI1Nzc5AAoJEOE4b9fvS1d5/NEP/RshKssht2YpkvxMzhj1wIj2 6ZAIWpq7lUlgaaORy/wVeGu29GVG1g5+Ov2KZdZjUVtVdG5JcRkdxihgwWL+AUT9 VfvEnlikEN+UTjJFE+1YmDEAynPpfAjv31UBLQg1LiKaUCHE8kABUFCJrUfmf6Pl A0CkiwdGCDjeY3BFdQG4wQm/rbnMSeyMK39qodqNfKk/vwDl67LSHvifBKzuHqcJ xcgKHVPNgN5T0HR6GLiBRO83PWOyQVYyX0/rMkQqTW4ggKGMHHtj15e+193sAyzX ke1+yrYQtA1nLa3bwSRz/gWJkxXEPo9ZsRxPYgk1F3wM/l63hGYBQ5dR7oR2hx69 hoAhmwQvv4GpJoDq5Tm8//Ko+joRcFrj1yNTNmQn/KSWlX7+PE8uMrh2IoVznXb+ 7BhWpeIx5/6txwlfGZzvdkH0KdK+Ahv0+QsKF0ZHm3S8T2fWsFLYfYR2cuC1UQYz 1W5vWaCUyt8nBZU7VR/+MWzyffZlwGkPmckbAxDX5CSn5EJTVs+y0PyhduYKd6RN 9i+8bmNHxPmehpjrs2En2iOhHiwO6q30wUTh0zY6CmNWmSsywUPlF8HSYwwScF0y 9C326aVegA29465gNdUw8njknwkksyUzFRBviGaB/ZzhjuA7AIvvdq/lpa3Eakhl DXfw03GJDBK9cJogc2x+ =Zio8 -----END PGP SIGNATURE-----