Re: [gentoo-dev] [PATCH 01/15] perl-module.eclass: Allow EAPI=6, ban PERL_EXPORT_PHASE_FUNCTIONS there, simplify perl dependency

["Andreas K. Huettel" <dilfridge@gentoo.org>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Am Samstag, 12. Dezember 2015, 12:49:09 schrieb Michał Górny:
> Dnia 11 grudnia 2015 22:02:57 CET, dilfridge@gentoo.org napisał(a):

> >+		case "${PERL_EXPORT_PHASE_FUNCTIONS:-yes}" in
> >+			yes)
> >+				EXPORT_FUNCTIONS ${PERL_EXPF}
> >+				;;
> >+			no)
> >+				debug-print "PERL_EXPORT_PHASE_FUNCTIONS=no"
> >+				;;
> >+			*)
> >+				die 
"PERL_EXPORT_PHASE_FUNCTIONS=${PERL_EXPORT_PHASE_FUNCTIONS} is
> >not supported by perl-module.eclass"
> >+				;;
> >+		esac
> 
> You could split this move, you know.

Yeah but it's probably more useful to change behavior now and then keep it 
consistent for whole EAPI=6... 

> >+		case "${GENTOO_DEPEND_ON_PERL:-yes}" in
> >+		yes)
> >+			case "${GENTOO_DEPEND_ON_PERL_SUBSLOT:-yes}" in
> >+			yes)
> >+				DEPEND="dev-lang/perl:="
> >+				;;
> >+			*)
> >+				DEPEND="dev-lang/perl"
> >+				;;
> >+			esac
> >+			RDEPEND="${DEPEND}"
> >+			;;
> >+		esac
> 
> Why don't you pack this stuff into a single trinary variable?

Good idea. Let's kill GENTOO_DEPEND_ON_PERL_SUBSLOT (never liked it, too long 
variable name :) and instead provide support for
GENTOO_DEPEND_ON_PERL=noslotop


- -- 

Andreas K. Huettel
Gentoo Linux developer 
dilfridge@gentoo.org
http://www.akhuettel.de/

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.1

iQJ8BAEBCgBmBQJWbIHoXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ0RkJDMzI0NjNBOTIwMDY5MTQ2NkMzNDBF
MTM4NkZEN0VGNEI1Nzc5AAoJEOE4b9fvS1d5/NEP/RshKssht2YpkvxMzhj1wIj2
6ZAIWpq7lUlgaaORy/wVeGu29GVG1g5+Ov2KZdZjUVtVdG5JcRkdxihgwWL+AUT9
VfvEnlikEN+UTjJFE+1YmDEAynPpfAjv31UBLQg1LiKaUCHE8kABUFCJrUfmf6Pl
A0CkiwdGCDjeY3BFdQG4wQm/rbnMSeyMK39qodqNfKk/vwDl67LSHvifBKzuHqcJ
xcgKHVPNgN5T0HR6GLiBRO83PWOyQVYyX0/rMkQqTW4ggKGMHHtj15e+193sAyzX
ke1+yrYQtA1nLa3bwSRz/gWJkxXEPo9ZsRxPYgk1F3wM/l63hGYBQ5dR7oR2hx69
hoAhmwQvv4GpJoDq5Tm8//Ko+joRcFrj1yNTNmQn/KSWlX7+PE8uMrh2IoVznXb+
7BhWpeIx5/6txwlfGZzvdkH0KdK+Ahv0+QsKF0ZHm3S8T2fWsFLYfYR2cuC1UQYz
1W5vWaCUyt8nBZU7VR/+MWzyffZlwGkPmckbAxDX5CSn5EJTVs+y0PyhduYKd6RN
9i+8bmNHxPmehpjrs2En2iOhHiwO6q30wUTh0zY6CmNWmSsywUPlF8HSYwwScF0y
9C326aVegA29465gNdUw8njknwkksyUzFRBviGaB/ZzhjuA7AIvvdq/lpa3Eakhl
DXfw03GJDBK9cJogc2x+
=Zio8
-----END PGP SIGNATURE-----