From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id C5DDA1384B4 for ; Fri, 11 Dec 2015 20:18:26 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 84E9421C02A; Fri, 11 Dec 2015 20:18:16 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 2696021C013; Fri, 11 Dec 2015 20:18:15 +0000 (UTC) Received: from localhost (unknown [91.246.99.151]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: bircoph) by smtp.gentoo.org (Postfix) with ESMTPSA id E0B47340894; Fri, 11 Dec 2015 20:18:12 +0000 (UTC) Date: Fri, 11 Dec 2015 23:18:08 +0300 From: Andrew Savchenko To: gentoo-dev@lists.gentoo.org Cc: Gilles Dartiguelongue , gentoo-commits@lists.gentoo.org Subject: Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: dev-cpp/gtkglextmm/, dev-cpp/gtkglextmm/files/ Message-Id: <20151211231808.dd293169b93d75710b155e70@gentoo.org> In-Reply-To: <1449861526.15018.2.camel@gentoo.org> References: <1449836240.fcc5f0fe910ec73b41adf3120255571baf896d4c.bircoph@gentoo> <1449861526.15018.2.camel@gentoo.org> X-Mailer: Sylpheed 3.4.3 (GTK+ 2.24.20; i686-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg="PGP-SHA512"; boundary="Signature=_Fri__11_Dec_2015_23_18_08_+0300_JM2sz=bJuvq4ZvPR" X-Archives-Salt: 6e8e8236-6745-48f4-ada0-c49cc814c386 X-Archives-Hash: 7d6b4426e49c45c8e3228fc35f9ed7f9 --Signature=_Fri__11_Dec_2015_23_18_08_+0300_JM2sz=bJuvq4ZvPR Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, 11 Dec 2015 20:18:46 +0100 Gilles Dartiguelongue wrote: > Le vendredi 11 d=C3=A9cembre 2015 =C3=A0 12:17 +0000, Andrew Savchenko a = =C3=A9crit=C2=A0: > > commit:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0fcc5f0fe910ec73b41adf3120255571baf= 896d4c > > Author:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Andrew Savchenko gen= too org> > > AuthorDate: Fri Dec 11 12:17:20 2015 +0000 > > Commit:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Andrew Savchenko gen= too org> > > CommitDate: Fri Dec 11 12:17:20 2015 +0000 > > URL:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0https://gitweb.gent= oo.org/repo/gentoo.git/commit/?id=3Dfcc5 > > f0fe > >=20 > > dev-cpp/gtkglextmm: fix bug 552686 > >=20 > > Fix underquoted aclocal definition. > >=20 > > Package-Manager: portage-2.2.26 > > Signed-off-by: Andrew Savchenko gentoo.org> > >=20 > > =C2=A0.../files/gtkglextmm-1.2.0-aclocal.patch=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| 11 ++++++ > > =C2=A0dev-cpp/gtkglextmm/gtkglextmm-1.2.0-r2.ebuild=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0| 46 > > ++++++++++++++++++++++ > > =C2=A02 files changed, 57 insertions(+) > >=20 > > diff --git a/dev-cpp/gtkglextmm/files/gtkglextmm-1.2.0-aclocal.patch > > b/dev-cpp/gtkglextmm/files/gtkglextmm-1.2.0-aclocal.patch > > new file mode 100644 > > index 0000000..32fa489 > > --- /dev/null > > +++ b/dev-cpp/gtkglextmm/files/gtkglextmm-1.2.0-aclocal.patch > > @@ -0,0 +1,11 @@ > > +--- gtkglextmm-1.2.0/m4macros/gtkglextmm.m4.orig 2004-05-18 > > 10:29:34.000000000 +0400 > > ++++ gtkglextmm-1.2.0/m4macros/gtkglextmm.m4 2015-08-07 > > 17:02:42.324065008 +0300 > > +@@ -222,7 +222,7 @@ > > + dnl AC_GTKGLEXTMM_SUPPORTS_MULTIHEAD([ACTION-IF-SUPPORTED [, > > ACTION-IF-NOT-SUPPORTED]]) > > + dnl Checks whether gtkglextmm supports multihead. > > + dnl > > +-AC_DEFUN(AC_GTKGLEXTMM_SUPPORTS_MULTIHEAD, > > ++AC_DEFUN([AC_GTKGLEXTMM_SUPPORTS_MULTIHEAD], > > + [ AC_LANG_SAVE > > +=C2=A0=C2=A0=C2=A0AC_LANG_CPLUSPLUS > > +=C2=A0=C2=A0=C2=A0AC_CACHE_CHECK([whether gtkglextmm supports multihea= d], > >=20 > > diff --git a/dev-cpp/gtkglextmm/gtkglextmm-1.2.0-r2.ebuild b/dev- > > cpp/gtkglextmm/gtkglextmm-1.2.0-r2.ebuild > > new file mode 100644 > > index 0000000..504827e > > --- /dev/null > > +++ b/dev-cpp/gtkglextmm/gtkglextmm-1.2.0-r2.ebuild > > @@ -0,0 +1,46 @@ > > +# Copyright 1999-2015 Gentoo Foundation > > +# Distributed under the terms of the GNU General Public License v2 > > +# $Id$ > > + > > +EAPI=3D5 > > +GCONF_DEBUG=3D"yes" > > + > > +inherit eutils gnome2 > > + > > +DESCRIPTION=3D"C++ bindings for gtkglext" > > +HOMEPAGE=3D"https://projects.gnome.org/gtkglext/" > > +SRC_URI=3D"mirror://sourceforge/gtkglext/${P}.tar.bz2" > > + > > +KEYWORDS=3D"~amd64 ~ppc ~x86" > > +IUSE=3D"doc" > > +SLOT=3D"1.0" > > +LICENSE=3D"GPL-2 LGPL-2.1" > > + > > +RDEPEND=3D" > > + >=3Dx11-libs/gtkglext-1 > > + >=3Ddev-libs/libsigc++-2.0 > > + >=3Ddev-cpp/glibmm-2.4:2 > > + >=3Ddev-cpp/gtkmm-2.4:2.4 > > + virtual/opengl > > +" > > +DEPEND=3D"${RDEPEND} > > + virtual/pkgconfig" > > + > > +src_prepare() { > > + # fix underquoted definition, bug 552686 > > + epatch "${FILESDIR}/${P}-aclocal.patch" > > + > > + # Remove docs from SUBDIRS so that docs are not installed, > > as > > + # we handle it in src_install. > > + sed -i -e 's|^\(SUBDIRS =3D.*\)docs\(.*\)|\1\2|' Makefile.in > > || \ > > + die "sed Makefile.in failed" > > + > > + gnome2_src_prepare > > +} > > + > > +src_install() { > > + gnome2_src_install > > + if use doc; then > > + dohtml -r docs/reference/html/* > > + fi > > +} >=20 > Why a revbump for this, it appears to be a build-time fix only. Becase it fixes file installed on a live filesystem, which affects global aclocal runs. Without this fix each aclocal run in the system with this package installed aclocal warning will be displayed: /usr/share/aclocal/gtkglextmm-1.2.m4:225: warning: underquoted definition of AC_GTKGLEXTMM_SUPPORTS_MULTIHEAD /usr/share/aclocal/gtkglextmm-1.2.m4:225: run info Automake 'Extending aclocal' /usr/share/aclocal/gtkglextmm-1.2.m4:225: or see http://www.gnu.org/software/automake/manual/automake.html#Extending-aclocal > Also it > appears to be missing an autools inherit and eautoreconf call. =20 No, it doesn't. This file is not used during gtkglextmm build, it is used by packages using gtkglextmm during their aclocal runs. Best regards, Andrew Savchenko --Signature=_Fri__11_Dec_2015_23_18_08_+0300_JM2sz=bJuvq4ZvPR Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJWay+AAAoJEPZTWjO6HuSNEZkP/RaFChY+Qvaz2h7WdmN115PY hQzaD52ccysfx9KjJmQAQWFvMnAp9n2VzGaBbMeXw4EnbMfq89V3GmUtqTueXnef kaF2VGlKf3we56atm8KBuRp/qzt09geyWKp6JncTdbFvPhfYPWVmEU56p3Z/paWD FcN2K7dzH9vfNP11UxXHNLvSJJ/q5Ab4iKaTyB64AUHLkHWj8VaccktC47W1NA2e p9f91AV/XD1eFDNlxXY2UVc4dybA5UvWl7DbFKEUrSBq7kvT11APe24xh1qJfVtD Rn4AoTwNR/rbw/uI96R1wevtVa5HVeJw+AeJEqshLBhPZtowKexUt1d9hUkpIZ3M Vy2jgi2wmJAhk+igV1i0wDf8E7CxBNuBU859If9Ja5qvWZmFZ4Q0eJ9UyVAvroVe 5FhIfb+P0+Ac15gzaLktsRsHMk4eEwHs+nqnabOsQQTpB4nydDmHJUT1lKultujl Rkg1ajFbhkq8jpI/gEG2O7wiwctiBWu5ux+2RbcwJ7gkY930LoaabOeY0JbBB+AG sw4HA58m4hs9s5RJOHgO+pKDNLvvmuTMA9JSw6kzyfl4GehW1sfXwTJ0h6dl9ic3 PQrTVmk2b3cSAYFsNNnl9jRAqVCjd4w7q/mATqqrBmJEqtN5u6bro8GHLbYD8Eru vDKc4dIJHe5vt5u4Rdqo =Z4B8 -----END PGP SIGNATURE----- --Signature=_Fri__11_Dec_2015_23_18_08_+0300_JM2sz=bJuvq4ZvPR--