Re: [gentoo-dev] [PATCH 02/13] python-utils-r1.eclass: Reorder implementations to semi-ascending order

["Michał Górny" <mgorny@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 2252 bytes --]

On Tue, 8 Dec 2015 09:19:57 +0100
Patrice Clement <monsieurp@gentoo.org> wrote:

> Sunday 06 Dec 2015 20:03:21, Michał Górny wrote :
> > Reorder the Python implementations to ascending version order, with
> > CPython listed first and other implementations in descending preference.
> > 
> > The previous ordering has been used for two reasons:
> > 
> > 1. There were packages which supported Python 3.x or PyPy partially but
> > their documentation builds or test functions required CPython 2.x.
> > The specific ordering caused python_export_best (the predecessor of
> > python_setup) to use CPython 2.x for those tasks. This is now replaced
> > by explicit implementation restrictions in python_setup.
> > 
> > 2. PyPy setup runs were usually slower than CPython, and CPython 3.x
> > runs were often slower due to 2to3 calls. Combined with parallel build
> > runs, this ordering caused slower builds to start earlier and sometimes
> > resulted in more efficient use of threads. However, nowadays we no
> > longer do parallel builds.
> > 
> > Therefore, it seems reasonable to finally reorder the implementations
> > into a more intuitive order.
> > ---
> >  eclass/python-utils-r1.eclass | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/eclass/python-utils-r1.eclass b/eclass/python-utils-r1.eclass
> > index 0bce6a9..3ea23a8 100644
> > --- a/eclass/python-utils-r1.eclass
> > +++ b/eclass/python-utils-r1.eclass
> > @@ -41,10 +41,10 @@ inherit toolchain-funcs
> >  # @DESCRIPTION:
> >  # All supported Python implementations, most preferred last.
> >  declare -g -r _PYTHON_ALL_IMPLS=(
> > -	jython2_5 jython2_7
> > -	pypy pypy3
> > -	python3_3 python3_4 python3_5
> >  	python2_7
> > +	python3_3 python3_4 python3_5
> > +	pypy pypy3
> > +	jython2_5 jython2_7
> >  )
> >  
> >  # @FUNCTION: _python_impl_supported
> > -- 
> > 2.6.3
> > 
> >   
> 
> Michal,
> 
> While at it, please delete jython2_5 from this list since jython versions < 2.7 are in
> the process of being purged from Portage. 
> 
> See https://bugs.gentoo.org/show_bug.cgi?id=552452

Will do, also from profiles.

-- 
Best regards,
Michał Górny
<http://dev.gentoo.org/~mgorny/>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 949 bytes --]