From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 8D5171384B4 for ; Sun, 6 Dec 2015 20:24:29 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 658AB21C119; Sun, 6 Dec 2015 20:24:10 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 7631821C114 for ; Sun, 6 Dec 2015 20:24:09 +0000 (UTC) Received: from symphony.aura-online.co.uk (154.189.187.81.in-addr.arpa [81.187.189.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: chewi) by smtp.gentoo.org (Postfix) with ESMTPSA id 2631134073B for ; Sun, 6 Dec 2015 20:24:07 +0000 (UTC) Date: Sun, 6 Dec 2015 20:23:56 +0000 From: James Le Cuirot To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH 2/9] multilib-build.eclass: Add missing error checks Message-ID: <20151206202356.5b7a0553@symphony.aura-online.co.uk> In-Reply-To: <1449428274-20439-3-git-send-email-mgorny@gentoo.org> References: <1449428274-20439-1-git-send-email-mgorny@gentoo.org> <1449428274-20439-3-git-send-email-mgorny@gentoo.org> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/6LL05fakG9XiRzkiWD0A5GR"; protocol="application/pgp-signature" X-Archives-Salt: 4df40b3c-4111-4e39-b4fd-8c558d074d58 X-Archives-Hash: d845fb481c072e248578e47609851071 --Sig_/6LL05fakG9XiRzkiWD0A5GR Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sun, 6 Dec 2015 19:57:47 +0100 Micha=C5=82 G=C3=B3rny wrote: > diff --git a/eclass/multilib-build.eclass > b/eclass/multilib-build.eclass index dd03553..8e58a2b 100644 > --- a/eclass/multilib-build.eclass > +++ b/eclass/multilib-build.eclass > @@ -262,19 +262,23 @@ multilib_for_best_abi() { > # runs (if any). Dies if header files differ. > multilib_check_headers() { > _multilib_header_cksum() { > - [[ -d ${ED}usr/include ]] && \ > - find "${ED}"usr/include -type f \ > - -exec cksum {} + | sort -k2 > + set -o pipefail > + > + if [[ -d ${ED}usr/include ]]; then > + find "${ED}"usr/include -type f \ > + -exec cksum {} + | sort -k2 > + fi > } Possibly being dumb here but isn't "set -o pipefail" a global operation? It will continue to take effect even after this function ends? --=20 James Le Cuirot (chewi) Gentoo Linux Developer --Sig_/6LL05fakG9XiRzkiWD0A5GR Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.1 iQJ8BAEBCgBmBQJWZJlcXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ1MjhERTZCRDg2OTFBNDM5MUZEQTJFRDQy MUM2MzIxMjlDNkQ3REU0AAoJECHGMhKcbX3kmBkP/0oOOG9TufLITa2Dl5fbldxN sFHZGuHI7d3XpqAY4g6Z1gjisu46r69maZwtiXEbQ12DIx/BSF/JOrynQ5sNOPDR 7ifQkY9GGMNe674q9pf62gR+IpGjzfFU8T0mrk0eSlOIfTBVlyprpnIaexmPzUSp gQEHjzAv+WDty88f3dvBKP3p2tjJTlHtbiIT2qjmmRdotnCtfXbwN5/AoZSZO/Iy GC2hl+5s7JChVMBz333zHtESkhsfQhyn6CAZ0lVpA3sYj4Or+9J/OwZWbiyjHtlZ LiUbdgICe6lcv9msHATkHYfo7IxJld5vE6X2Om8XrBvtnlqlSb+Cek3R9i3BlYxf lm1w8T5tjN9v75qktv1I7QIuDEBiW+3dhAunfORDi57Zhq81PJ6J9muQvLFzGkfc pLTdsf7iFi6++y5hOcHOtqgIVb4HjfQ7POYEJ34kjpvkbxmI5hH5Zmfk2N78nXLH r6ANk602SHVSdYHPSzAxE2Dz/BVvl++Z3ld+a62+ldKqDed8CUQ3zmYnyK3f6X9Q q8vrz9fX4jU4cSniSo00FYKr0oiu0nkpUq/ReEu52EiYg5DWaD5+Aepb65XIAeWT XBN5NUh6dvEP4wQUSBYhfnwlb7M2THt3gVDNuQl51f33tFH18EDMEXo1YhtSgpZM 6upQbTqDg+kB5LV68fZV =TZpV -----END PGP SIGNATURE----- --Sig_/6LL05fakG9XiRzkiWD0A5GR--