From: Alexis Ballier <aballier@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] RFD: Replacement for versionator.eclass in PMS (for EAPI 7?)
Date: Wed, 2 Dec 2015 13:18:09 +0100 [thread overview]
Message-ID: <20151202131809.5bd3dd25@gentoo.org> (raw)
In-Reply-To: <22110.56899.534907.395201@a1i15.kph.uni-mainz.de>
On Wed, 2 Dec 2015 13:04:19 +0100
Ulrich Mueller <ulm@gentoo.org> wrote:
> >>>>> On Wed, 2 Dec 2015, Alexis Ballier wrote:
>
> > What's the point, need or advantage in moving this to
> > all-ebuild-scope?
>
> > Usually eclass refactor/api cleanup are done in a -r{n+1} while
> > deprecating -rn. This would have the advantage that you can quickly
> > post a complete implementation and get wider reviews.
>
> A proof-of-concept implementation for the two version manipulation
> functions is here:
> https://482170.bugs.gentoo.org/attachment.cgi?id=418072
> Add some comments and you'll have a working eclass. :)
Yes, but I don't see the point of defining bash code in PMS and
copy/pasting it in every compliant PM, when said code used to be in
only one place. Sounds like a "regression" to me.
[...]
> Also version_test is missing, but the idea there was to avoid
> redundancy and use the implementation that already exists in the
> package manager (which does version comparison all the time). This is
> one of the reasons for moving it to the package manager.
well, then maybe version_test is the only one that makes sense to be
added to PM. Though it is unclear to me how to interface it: spawning a
python interp. every time the function is called doesn't seem to be a
terrible idea wrt performance.
next prev parent reply other threads:[~2015-12-02 12:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-28 21:14 [gentoo-dev] RFD: Replacement for versionator.eclass in PMS (for EAPI 7?) Ulrich Mueller
2015-11-29 23:23 ` Peter Stuge
2015-11-30 6:28 ` Michał Górny
2015-12-02 11:03 ` Alexis Ballier
2015-12-02 12:04 ` Ulrich Mueller
2015-12-02 12:18 ` Alexis Ballier [this message]
2015-12-07 5:37 ` Jason Zaman
2015-12-07 7:00 ` Michał Górny
2015-12-07 7:41 ` Ulrich Mueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151202131809.5bd3dd25@gentoo.org \
--to=aballier@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox