From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 4317A1384B4 for ; Sun, 29 Nov 2015 09:58:08 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 5C1F921C06E; Sun, 29 Nov 2015 09:57:59 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 6C04821C011 for ; Sun, 29 Nov 2015 09:57:57 +0000 (UTC) Received: from pomiot (d202-251.icpnet.pl [109.173.202.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 291EC33D3CF; Sun, 29 Nov 2015 09:57:52 +0000 (UTC) Date: Sun, 29 Nov 2015 10:57:34 +0100 From: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= To: Justin Lecher Cc: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH 4/8] virtualx.eclass: Ban deprecated functionality in EAPI > 5 Message-ID: <20151129105734.20600ae1.mgorny@gentoo.org> In-Reply-To: <1448727664-25886-4-git-send-email-jlec@gentoo.org> References: <5E6CCF53-839B-4BBD-B9BB-BFF4D70612A0@gentoo.org> <1448727664-25886-1-git-send-email-jlec@gentoo.org> <1448727664-25886-4-git-send-email-jlec@gentoo.org> Organization: Gentoo X-Mailer: Claws Mail 3.13.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/+V7oWESydRFxDSY0ZTaQLP3"; protocol="application/pgp-signature" X-Archives-Salt: ec30c1b9-ccbf-46fb-8af8-6779ef1eeb7d X-Archives-Hash: 8f376ca33a80a0b912ac2b112dcbd1a5 --Sig_/+V7oWESydRFxDSY0ZTaQLP3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sat, 28 Nov 2015 17:21:00 +0100 Justin Lecher wrote: > Signed-off-by: Justin Lecher > --- > eclass/virtualx.eclass | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/eclass/virtualx.eclass b/eclass/virtualx.eclass > index 230897b..a5e5457 100644 > --- a/eclass/virtualx.eclass > +++ b/eclass/virtualx.eclass > @@ -59,6 +59,8 @@ case ${VIRTUALX_REQUIRED} in > RDEPEND=3D"" > ;; > optional|tests) > + [[ ${EAPI} =3D=3D [2345] ]] \ > + || die 'Values "optional" and "tests" are unsupported for VIRTUALX_RE= QUIRED' You don't mention EAPI here, which can get confusing. > # deprecated section YAY. > eqawarn "VIRTUALX_REQUIRED=3Doptional and VIRTUALX_REQUIRED=3Dtests ar= e deprecated." > eqawarn "You can drop the variable definition completely from ebuild," > @@ -177,6 +179,9 @@ virtualmake() { > Xmake() { > debug-print-function ${FUNCNAME} "$@" > =20 > + [[ ${EAPI} =3D=3D [2345] ]] \ > + || die "${FUNCNAME} is removed in EAPI > 5; use Xemake -j1 instead" > + > eqawarn "you should not execute make directly" > eqawarn "rather execute Xemake -j1 if you have issues with parallel mak= e" > VIRTUALX_COMMAND=3D"emake -j1" virtualmake "$@" Still, if you introduced virtx earlier, you wouldn't have to change this die message later on ;-). --=20 Best regards, Micha=C5=82 G=C3=B3rny --Sig_/+V7oWESydRFxDSY0ZTaQLP3 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJWWswOXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ2REJCMDdDQzRGMERBRDA2RUEwQUZFNDFC MDdBMUFFQUVGQjQ0NjRFAAoJELB6GurvtEZOhGEP/jDpdIWU74HgOVbuA6B+kQin hmumf4wi2Tmo8Xtp9W54do7tYWjo/iBBdNFUTKOZDxdkQ4HngZpOI2G++TRTdk6S +MiTVr5/8ctMdgjo34cDUOpoL7KDuP2FwlR1+Qqn+gP+zcTi0NIH9UwgXnzBpN9v iQiCnwidX7GZn5tf0mUiAw/l8zGfkWCOMgmgBBVd/B23+irbLg10TxJdrvJVYfxu idxUp1DNPf9BHQ3Q198ZWGHXKrD6dz7rmrUUieB2G98uMjXPQT4cpp4e6DWQLpiV uc6kx7BXIbdy+TpHkubvJDuRCTMnsMLY603Oxn9aDfxeOP8HuK40jxKMBjwmZFkB 5gQP2ii5z3A4zsWn/FDdjBDKfSsQnz7i5kOF921sJQTVT1AAQQad2ltDXSv3zmbD 1yy0HkmOiteSwMF8sUDZkhTuvHppj1knVJA8n+HZ26XvENkVk03ZqVn8aWY2qndA 5hPeU2NwW+TV2UsEf4iY4VQVlNwWELdG1a1BjJ7Uix3m+NgYwSMgsX7xxE3hD/Ni GZ+JVsLEIaPqWUufp2HLjwLDQC9nls9oG7yYTfyRA574zSCiIkC67c87XyMaO3sS K1/7IdMoRSHxFOuM4gly5o0aFB7EobpD7smlCgm0e4SnpAUXUG5OjUMPkyn1XN6u zK5Bt6roh9zd4G+9e8Hj =XmUC -----END PGP SIGNATURE----- --Sig_/+V7oWESydRFxDSY0ZTaQLP3--