From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id E032D1384B4 for ; Fri, 27 Nov 2015 13:15:30 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 1310421C0EE; Fri, 27 Nov 2015 13:15:22 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 1940621C023 for ; Fri, 27 Nov 2015 13:15:20 +0000 (UTC) Received: from pomiot (d202-251.icpnet.pl [109.173.202.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 175C033E2EB; Fri, 27 Nov 2015 13:15:17 +0000 (UTC) Date: Fri, 27 Nov 2015 14:15:08 +0100 From: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH 1/2] python-utils-r1.eclass: python_fix_shebang, skip empty files Message-ID: <20151127141508.65c95988.mgorny@gentoo.org> In-Reply-To: <1448577009-32161-1-git-send-email-mgorny@gentoo.org> References: <1448221870-17269-1-git-send-email-mgorny@gentoo.org> <1448577009-32161-1-git-send-email-mgorny@gentoo.org> Organization: Gentoo X-Mailer: Claws Mail 3.13.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/46j0f=f.fgvqD3CIkRnxuP+"; protocol="application/pgp-signature" X-Archives-Salt: 7821610c-146f-4be3-b4f5-55423df57438 X-Archives-Hash: 1740c0cf033a71a7465cd0779a5962ff --Sig_/46j0f=f.fgvqD3CIkRnxuP+ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, 26 Nov 2015 23:30:08 +0100 Micha=C5=82 G=C3=B3rny wrote: > Skip empty files when traversing directories in python_fix_shebangs. > This prevents read from failing on them, and avoids opening them > unnecessarily. > --- > eclass/python-utils-r1.eclass | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) I'm withdrawing this one. 'read' is equally unhappy with empty files and files having no newline character (i.e. very ugly files), so no ||die for it. --=20 Best regards, Micha=C5=82 G=C3=B3rny --Sig_/46j0f=f.fgvqD3CIkRnxuP+ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJWWFdcXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ2REJCMDdDQzRGMERBRDA2RUEwQUZFNDFC MDdBMUFFQUVGQjQ0NjRFAAoJELB6GurvtEZOhyYQAM90IXvGic/AwYHPER5rAcYL 5hgJxLjKp69WGjrRbqyq2hok0Dl7p2Qvdu8jnh008OcR/H2HXKRWQYYjx2oj/+jC LkbmpxTnwK9r3H4wnoy3DrJb4TqLGsbRlGtqKmmmWS4Rd9beoWvhdmT+gMMto4Mv AMrxiQSs/N7uXOfkLTHtkWZ3aSYuhSYJFt9r4sBZUpSojkJgW6raPNxDPg/ZCpa9 OS+rsmhQNGPgf2fGgetnbzR+K+0tXAcuR9HUhIkoyhCRNy7IOvS3Wzx0xOSBYZIn sQ9yn5FXiC8Se31xj3whJTWZ/O6G9hh+LqQTFC3mf1AiC/Peioegn6RYVaTonvwi UzKaNOqcK00hXF7CRxeRVwtc13o7eNb1chg6x2FD8bNTypWu0cApLQFR4QT81Xdp 9wFckNh9iZylW7SI01dGuPT7EnPgxc81MpdQuKZJatd1Mh6Qjy6z1uyzzBcwdFfz NzEoAK9yv8ovqu3BIzJeh8KdEZNwuwpD6RQ/VIF79nTV3swnHJIWOHZ/iMxqzhgF ZZCgkgKj1Hoip3gr/dYaSVQ0Y+H/GDjvoiLJlRcExDbc69UhLWTUzFFtai/gm5xY R/HV4EeTGYqrsBCPMORFeYxLyhSzNwqY85LACF8p4uLRyzcmPHYF0CJNjvh4UrIm 29DAWGaEi28nYdHLdQvm =wd/i -----END PGP SIGNATURE----- --Sig_/46j0f=f.fgvqD3CIkRnxuP+--