From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 104541384B4 for ; Thu, 26 Nov 2015 22:27:12 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id C38AD21C07B; Thu, 26 Nov 2015 22:26:59 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id D239421C074 for ; Thu, 26 Nov 2015 22:26:58 +0000 (UTC) Received: from pomiot (d202-251.icpnet.pl [109.173.202.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 556CE340545; Thu, 26 Nov 2015 22:26:57 +0000 (UTC) Date: Thu, 26 Nov 2015 23:26:42 +0100 From: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH 03/29] python-utils-r1.eclass: Add missing ||die on file read Message-ID: <20151126232642.3149fcf8.mgorny@gentoo.org> In-Reply-To: <20151125171624.508e6b97.mgorny@gentoo.org> References: <1448221870-17269-1-git-send-email-mgorny@gentoo.org> <1448221870-17269-4-git-send-email-mgorny@gentoo.org> <20151125171624.508e6b97.mgorny@gentoo.org> Organization: Gentoo X-Mailer: Claws Mail 3.13.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/.iMu9k3Gvap/xWypA7DOf_8"; protocol="application/pgp-signature" X-Archives-Salt: 7509507a-a693-44c1-87ec-a7be454f6dfd X-Archives-Hash: 7638e1fd625ed5492fe6dd00a2e9600c --Sig_/.iMu9k3Gvap/xWypA7DOf_8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 25 Nov 2015 17:16:24 +0100 Micha=C5=82 G=C3=B3rny wrote: > On Sun, 22 Nov 2015 20:50:44 +0100 > Micha=C5=82 G=C3=B3rny wrote: >=20 > > --- > > eclass/python-utils-r1.eclass | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > >=20 > > diff --git a/eclass/python-utils-r1.eclass b/eclass/python-utils-r1.ecl= ass > > index 0a04e12..201b0c4 100644 > > --- a/eclass/python-utils-r1.eclass > > +++ b/eclass/python-utils-r1.eclass > > @@ -1038,12 +1038,12 @@ python_fix_shebang() { > > local shebang i > > local error=3D from=3D > > =20 > > - IFS=3D read -r shebang <"${f}" > > + IFS=3D read -r shebang <"${f}" || die =20 >=20 > This gives failure for empty files. We need to revert it, and possibly > find a better way of distinguishing I/O failure from 'no input' error. Going to add two more patches, one of them fixing this. --=20 Best regards, Micha=C5=82 G=C3=B3rny --Sig_/.iMu9k3Gvap/xWypA7DOf_8 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJWV4cjXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ2REJCMDdDQzRGMERBRDA2RUEwQUZFNDFC MDdBMUFFQUVGQjQ0NjRFAAoJELB6GurvtEZOfpIP/3r3iqJ7yYgxxro4b5jN8yUJ Hp05r98zaaoHduUMPqpqyMhmHxPiFzX2v95SQkaG3jsXG0vubFOGedd/f2i+mtrS zUfgzDoTXYA/6KP38rOcjTxiI1n32Rwxye1GVBJp6ffI8mt+GcgJEFAT9ha5FlSx 9TTXpk5eQ8/XB9C3CHGlV8o5xTw8yYH6UiiLTSncpigEvpsdZa1DwZrSQhLhf6NV Qbdw+mzOT9z5Yo1pbeoKKftOBsMkyMkQ19beo/dJwN30R0uF9ko7+rC1fzIIlleN RBfvTz4CkpVIFEt0ZjsuVpnYXHcHafAK8lwmsMSpnPEsHnOQb1R0DLz5ft7iYZ/L SpCidSBQN6NXCXDCN4y7sY7fZhGVFuSHVtnYMBW8IojNsfNf3xLFivDk0jnskUMK YqemehURxDCtHECSeMO74+rWB8dcHhDkYTrKvNl0mBkdg9vYejHpgxS+SZhvGMbz pMOlEfdXcXesXZLCpKZ+00ckz6a/AJz54SD3qLB1NBMperpqj3Gg8jQgT+sT20S8 S/7IZS6x7uw8O7gXCH/ag+taqLJQDKWJr3yNvDLG9TMwHUnT49tl6wd0PESVLIf3 sproLUcOS8JXD9qrWbQL/HaoiVo/H2T0YNIEjFYuB3zk7hMxF3vLZQPfqP8mVnVx Sbq9uEbnfEi2k6SjT6gh =oDn5 -----END PGP SIGNATURE----- --Sig_/.iMu9k3Gvap/xWypA7DOf_8--