Re: [gentoo-dev] [PATCH 03/29] python-utils-r1.eclass: Add missing ||die on file read

["Michał Górny" <mgorny@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 959 bytes --]

On Wed, 25 Nov 2015 17:16:24 +0100
Michał Górny <mgorny@gentoo.org> wrote:

> On Sun, 22 Nov 2015 20:50:44 +0100
> Michał Górny <mgorny@gentoo.org> wrote:
> 
> > ---
> >  eclass/python-utils-r1.eclass | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/eclass/python-utils-r1.eclass b/eclass/python-utils-r1.eclass
> > index 0a04e12..201b0c4 100644
> > --- a/eclass/python-utils-r1.eclass
> > +++ b/eclass/python-utils-r1.eclass
> > @@ -1038,12 +1038,12 @@ python_fix_shebang() {
> >  			local shebang i
> >  			local error= from=
> >  
> > -			IFS= read -r shebang <"${f}"
> > +			IFS= read -r shebang <"${f}" || die  
> 
> This gives failure for empty files. We need to revert it, and possibly
> find a better way of distinguishing I/O failure from 'no input' error.

Going to add two more patches, one of them fixing this.

-- 
Best regards,
Michał Górny
<http://dev.gentoo.org/~mgorny/>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 949 bytes --]