From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 274A11384B4 for ; Sun, 22 Nov 2015 21:15:13 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 813F921C006; Sun, 22 Nov 2015 21:14:50 +0000 (UTC) Received: from zhbdzmsp-smta15.bluewin.ch (zhbdzmsp-smta15.bluewin.ch [195.186.99.132]) by pigeon.gentoo.org (Postfix) with ESMTP id 55192E0653 for ; Sun, 22 Nov 2015 21:14:49 +0000 (UTC) Received: from [195.186.227.130] ([195.186.227.130:39687] helo=zhhdzmsp-smta12.bluewin.ch) by zhbdzmsp-smta15.bluewin.ch (envelope-from ) (ecelerity 3.5.10.45038 r(Core:3.5.10.0)) with ESMTP id 4A/F9-07654-84032565; Sun, 22 Nov 2015 21:14:48 +0000 Received: from localhost (77.56.202.9) by zhhdzmsp-smta12.bluewin.ch (8.5.142) (authenticated as meier_markus) id 5620C446022B1B75 for gentoo-dev@lists.gentoo.org; Sun, 22 Nov 2015 21:14:48 +0000 Date: Sun, 22 Nov 2015 22:14:37 +0100 From: Markus Meier To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH 25/29] distutils-r1.eclass: Ban EXAMPLES in EAPI 6 Message-ID: <20151122221437.42b2f85e@gentoo.org> In-Reply-To: <1448221870-17269-26-git-send-email-mgorny@gentoo.org> References: <1448221870-17269-1-git-send-email-mgorny@gentoo.org> <1448221870-17269-26-git-send-email-mgorny@gentoo.org> X-Mailer: Claws Mail 3.13.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/nqk6=lk1LEvPaxhxBiVtZ+/"; protocol="application/pgp-signature" X-Archives-Salt: 71c2b745-b1c1-428e-aacb-20dc468c7b3a X-Archives-Hash: 300b3290f0950270cd8f77b425542598 --Sig_/nqk6=lk1LEvPaxhxBiVtZ+/ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sun, 22 Nov 2015 20:51:06 +0100 Micha=C5=82 G=C3=B3rny wrote: > --- > eclass/distutils-r1.eclass | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass > index e632202..e55e2e4 100644 > --- a/eclass/distutils-r1.eclass > +++ b/eclass/distutils-r1.eclass > @@ -583,6 +583,8 @@ distutils-r1_python_install_all() { > einstalldocs > =20 > if declare -p EXAMPLES &>/dev/null; then > + [[ ${EAPI} =3D=3D [45] ]] && die "EXAMPLES are banned in > EAPI ${EAPI}" + I think the logic is the wrong way around and should be "|| die ..." > local INSDESTTREE=3D/usr/share/doc/${PF}/examples > doins -r "${EXAMPLES[@]}" > docompress -x "${INSDESTTREE}" Regards, Markus --Sig_/nqk6=lk1LEvPaxhxBiVtZ+/ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlZSMD4ACgkQkKaRLQcq0GJKVgCePAda0OtIhAnC+O7aYr+jLjpI HiMAn0QM0Ig1QA6srV+KF0eL5S42n6f+ =V28n -----END PGP SIGNATURE----- --Sig_/nqk6=lk1LEvPaxhxBiVtZ+/--