Re: [gentoo-dev] [PATCH 25/29] distutils-r1.eclass: Ban EXAMPLES in EAPI 6

[Markus Meier <maekke@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 768 bytes --]

On Sun, 22 Nov 2015 20:51:06 +0100
Michał Górny <mgorny@gentoo.org> wrote:

> ---
>  eclass/distutils-r1.eclass | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass
> index e632202..e55e2e4 100644
> --- a/eclass/distutils-r1.eclass
> +++ b/eclass/distutils-r1.eclass
> @@ -583,6 +583,8 @@ distutils-r1_python_install_all() {
>  	einstalldocs
>  
>  	if declare -p EXAMPLES &>/dev/null; then
> +		[[ ${EAPI} == [45] ]] && die "EXAMPLES are banned in
> EAPI ${EAPI}" +

I think the logic is the wrong way around and should be "|| die ..."

>  		local INSDESTTREE=/usr/share/doc/${PF}/examples
>  		doins -r "${EXAMPLES[@]}"
>  		docompress -x "${INSDESTTREE}"


Regards,
Markus

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]