[gentoo-dev] Re: [PATCH v1] enable gccgo for all platform

[Ryan Hill <rhill@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1411 bytes --]

On Mon,  2 Nov 2015 12:17:26 -0500
Leno Hou <lenohou@gmail.com> wrote:

> 1. go compiler only support x86 platform
> 2. gcc 5 includes go command to build go apps
> 3. for coreos enablement, it's use gcc 5 to build go apps

> diff --git a/app-admin/consul-template/consul-template-0.9.0-r1.ebuild
> b/app-admin/consul-template/consul-template-0.9.0-r1.ebuild index
> cbc1059..a24ec80 100644 ---
> a/app-admin/consul-template/consul-template-0.9.0-r1.ebuild +++
> b/app-admin/consul-template/consul-template-0.9.0-r1.ebuild @@ -14,7 +14,10
> @@ LICENSE="MPL-2.0" SLOT="0"
>  IUSE="test"
>  
> -DEPEND=">=dev-lang/go-1.4:=  
> +DEPEND="|| (
> +		>=dev-lang/go-1.4:=
> +		>=sys-devel/gcc-5.1.0:=[go]
> +	)
>  	test? ( dev-go/go-tools )
>  	app-admin/consul
>  	app-admin/vault"

You cannot simply have a dependency on gcc like this.  Just because there is a
compiler installed that satisfies the dependency doesn't mean that compiler is
the one currently being used.  I could have gcc 5 with go support installed
while using gcc 6 without go.  You need to either do a compile test or query
the compiler in some way to ensure the needed support is there.  Look at the
fortran virtual and fortran-2 eclass for an example.


-- 
Ryan Hill                        psn: dirtyepic_sk
   gcc-porting/toolchain/wxwidgets @ gentoo.org

47C3 6D62 4864 0E49 8E9E  7F92 ED38 BD49 957A 8463

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 475 bytes --]