From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 05EDD1384B4 for ; Wed, 11 Nov 2015 09:10:11 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 60C1A21C038; Wed, 11 Nov 2015 09:09:57 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 4C609E086B for ; Wed, 11 Nov 2015 09:09:56 +0000 (UTC) Received: from pomiot (d202-251.icpnet.pl [109.173.202.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 2B7A533E01A; Wed, 11 Nov 2015 09:09:53 +0000 (UTC) Date: Wed, 11 Nov 2015 10:09:43 +0100 From: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= To: Mike Frysinger Cc: gentoo-dev@lists.gentoo.org, Justin Lecher Subject: Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/ Message-ID: <20151111100944.77313cc6.mgorny@gentoo.org> In-Reply-To: <20151110235303.GQ5154@vapier.lan> References: <1446206629.df8e399c9bac2dc30d7cf69c2462a81729a3ae69.jlec@gentoo> <20151030182008.44e0c324.mgorny@gentoo.org> <20151031070621.GO5154@vapier.lan> <20151031090843.19fee262.mgorny@gentoo.org> <20151110235303.GQ5154@vapier.lan> Organization: Gentoo X-Mailer: Claws Mail 3.13.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/EHaIJ5Rh4Hy0Nvn9CZ2zoGS"; protocol="application/pgp-signature" X-Archives-Salt: f228dd04-9968-4d7d-a85e-654d12974b6e X-Archives-Hash: fede238be677425a5a680aa6b6e1603d --Sig_/EHaIJ5Rh4Hy0Nvn9CZ2zoGS Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, 10 Nov 2015 18:53:03 -0500 Mike Frysinger wrote: > On 31 Oct 2015 09:08, Micha=C5=82 G=C3=B3rny wrote: > > On Sat, 31 Oct 2015 03:06:21 -0400 Mike Frysinger wrote: =20 > > > On 30 Oct 2015 18:20, Micha=C5=82 G=C3=B3rny wrote: =20 > > > > On Fri, 30 Oct 2015 12:03:59 +0000 (UTC) "Justin Lecher" wrote: = =20 > > > > > --- a/eclass/distutils-r1.eclass > > > > > +++ b/eclass/distutils-r1.eclass > > > > > @@ -322,8 +322,7 @@ distutils-r1_python_prepare_all() { > > > > > =20 > > > > > _distutils-r1_disable_ez_setup > > > > > =20 > > > > > - if [[ ${DISTUTILS_IN_SOURCE_BUILD} && ! ${DISTUTILS_SINGLE_IMPL= } ]] > > > > > - then > > > > > + if [[ ${DISTUTILS_IN_SOURCE_BUILD} && ! ${DISTUTILS_SINGLE_IMPL= } ]]; then =20 > > > >=20 > > > > This was intentionally wrapped to stay within 72-column line width.= Not > > > > saying the eclass is perfect in keeping text width, especially with > > > > others committing random changes to it, but that's no reason to > > > > introduce further offenders. =20 > > >=20 > > > Gentoo has never had a hard 80-col rule let alone 72-cols. forcing a= wrap > > > here makes no sense and the new version is an improvement. =20 > >=20 > > For years, Gentoo was unable to make *any* *sane* *global* rules. Which > > doesn't mean everything needs to be as crappy as the overall Gentoo > > 'quality'. =20 >=20 > you forgot "imo". we've had commonly accepted standards that people gene= rally > kept to, some of which were more fuzzy than others. but we've never had = a hard > 80 col rule and claiming that 72 col is an improvement is pretty hard to > swallow. there's no reasonable argument for such minimal restrictions in > todays's world, and "it's always been that way" doesn't fly. How about this; my terminal barely fits 90 characters? Of course, I could then just shot arbitrarily at 90 but for 10 characters... I'd rather use the old standard 80. Minus 8 characters for friendly e-mail quoting, which is also kinda 'old standard'. --=20 Best regards, Micha=C5=82 G=C3=B3rny --Sig_/EHaIJ5Rh4Hy0Nvn9CZ2zoGS Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJWQwXZXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ2REJCMDdDQzRGMERBRDA2RUEwQUZFNDFC MDdBMUFFQUVGQjQ0NjRFAAoJELB6GurvtEZOZZUQANhNNFtkWQSlEhJFoB9nmLZs F7PdmmEatk8+5nbu86ibIpoux0HxPHtloPBubxRmgNE3fulebTlCsCphv/NtX+oA BZqtUKpTpOtupW+pOlQq9QEOhWSfHfdm2yr/hjyy4S32Y+P+wsGpY1+WLSLkOC2j TD9ASsqWiuQTMFYtqPj7rQLjy6WgugBMJSo2VqWhddjnaU29mJt073YFPJmUQPnq 2Yz4BwT6uHR8n8JPa9nDdLMN8YaIw8c2unOEsTZCPhNa/+Q6Zey5liuGLR8Arzh6 rs0MrpJfbUX1iXFPCNHl4Mez6u4dnzqAGAzL1WWQsQ3wXrHCYSwxU0RRSfyySipy CUWjUM2SnSKFt+giX4t58gPydQsZQNPyrV9CgkEaoJzen03/SfAGP6Czp83TvVO2 GfNGWV8A7VPv3DLo3NIcfDRiSLZKlNkEgXfECA2eyK2w/9+VcrLvTSuqlr3uFsZL JFZZOfMS8ux7W4ShAMddDYLYXoaaVlTlGwG6RpS3eATVfeKIJj/9wkfFMJtmeQaU 5mFx2qqvsrgezl1BuyZJz2D4ld+49Clvv8jkkA3hcDT12jpJ0lvmCuTx+vDwXHoo 5RazhvvXfVwAOx4FqJlVYGLwQRi59e6od166SFHUcU8ehxUybwRcb7P/M2/d5iJW 2FML2gykUVtxv908Q0lY =ESMA -----END PGP SIGNATURE----- --Sig_/EHaIJ5Rh4Hy0Nvn9CZ2zoGS--