Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

[Ian Delaney<idella4@gentoo.org>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Fri, 30 Oct 2015 18:20:08 +0100
Michał Górny <mgorny@gentoo.org> wrote:

> On Fri, 30 Oct 2015 12:03:59 +0000 (UTC)
> "Justin Lecher" <jlec@gentoo.org> wrote:
> 
> > commit:     df8e399c9bac2dc30d7cf69c2462a81729a3ae69
> > Author:     Justin Lecher <jlec <AT> gentoo <DOT> org>
> > AuthorDate: Fri Oct 30 10:18:05 2015 +0000
> > Commit:     Justin Lecher <jlec <AT> gentoo <DOT> org>
> > CommitDate: Fri Oct 30 12:03:49 2015 +0000
> > URL:
> > https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=df8e399c
> > 
> > eclass: Use consistent place for then in if clause
> 
> Excuse me but who are you exactly to take a random eclass and commit
> random style changes inside without even bothering to contact
> the author?
> 

Well, what's this? he selected a random eclass? Then he recklessly
committed a random style change? To my observation, the lead recruiter
specifically selected the distutils-r1 eclass, not some random one like
base.eclass, and carefully edited a couple of lines to put "; then" at
the end of a line as is done in most any ebuild. So how RANDOM is that?
In fact it isn't, however you have no hesitation in taking him to task
not only over its randomness which isn't, but that he had the gaul to do
it at all.

Was it not you who insisted that I assign a bug over the func
distutils_install_for_testing and you insisted I assign it to the
python team, not to you as I did. You lectured me to follow the rules
stating that it belongs to the python herd / project / w/e which may
be authored by its members any time in the future. It seems you want it
both ways.

jlec is not only a member of python team but he is high ranked. That
exactly is who he is.
> Not to mention this commit message is incorrect as it doesn't state
> which eclass was modified.
> 

This is in fact correct.
> > 
> > Signed-off-by: Justin Lecher <jlec <AT> gentoo.org>
> > 
> >  eclass/distutils-r1.eclass | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass
> > index 185dd4f..dbd27a7 100644
> > --- a/eclass/distutils-r1.eclass
> > +++ b/eclass/distutils-r1.eclass
> > @@ -322,8 +322,7 @@ distutils-r1_python_prepare_all() {
> >  
> >  	_distutils-r1_disable_ez_setup
> >  
> > -	if [[ ${DISTUTILS_IN_SOURCE_BUILD} && !
> > ${DISTUTILS_SINGLE_IMPL} ]]
> > -	then
> > +	if [[ ${DISTUTILS_IN_SOURCE_BUILD} && !
> > ${DISTUTILS_SINGLE_IMPL} ]]; then
> 
> This was intentionally wrapped to stay within 72-column line width.
> Not saying the eclass is perfect in keeping text width, especially
> with others committing random changes to it, but that's no reason to
> introduce further offenders.
> 

there's that random again. Once and for all mgorny get off your high
horse.

> >  		# create source copies for each implementation
> >  		python_copy_sources
> >  	fi
> > 
> 
> 
> 



- -- 
kind regards

Ian Delaney
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.1

iKYEARECAGYFAlY0u/1fFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3Bl
bnBncC5maWZ0aGhvcnNlbWFuLm5ldDdDQUM1OUY0ODkzMERBREU1NUQ1RjJBRkIy
OEVDMjEzQjgwNzJCMEQACgkQso7CE7gHKw3xZQCgyQb6Tyuw73CiBHgxXm/bvPX7
L1EAn0UfLOZTERZpMJN1VQXIgb81AkE6
=yt+k
-----END PGP SIGNATURE-----


-- 
kind regards

Ian Delaney