From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id C4BFB13888F for ; Sat, 31 Oct 2015 08:09:13 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 61E19E0826; Sat, 31 Oct 2015 08:09:04 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 49598E07EE for ; Sat, 31 Oct 2015 08:09:03 +0000 (UTC) Received: from pomiot (d202-251.icpnet.pl [109.173.202.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id E3109340A98; Sat, 31 Oct 2015 08:08:58 +0000 (UTC) Date: Sat, 31 Oct 2015 09:08:43 +0100 From: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= To: Mike Frysinger Cc: gentoo-dev@lists.gentoo.org, Justin Lecher Subject: Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/ Message-ID: <20151031090843.19fee262.mgorny@gentoo.org> In-Reply-To: <20151031070621.GO5154@vapier.lan> References: <1446206629.df8e399c9bac2dc30d7cf69c2462a81729a3ae69.jlec@gentoo> <20151030182008.44e0c324.mgorny@gentoo.org> <20151031070621.GO5154@vapier.lan> Organization: Gentoo X-Mailer: Claws Mail 3.13.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/b+xKTZUonvvW02v9lGiqPH_"; protocol="application/pgp-signature" X-Archives-Salt: 6a1c20ef-d2b6-49e9-892e-5287946a7ba8 X-Archives-Hash: 9930066aefef450ad220aaf4b93666fa --Sig_/b+xKTZUonvvW02v9lGiqPH_ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sat, 31 Oct 2015 03:06:21 -0400 Mike Frysinger wrote: > On 30 Oct 2015 18:20, Micha=C5=82 G=C3=B3rny wrote: > > On Fri, 30 Oct 2015 12:03:59 +0000 (UTC) "Justin Lecher" wrote: =20 > > > commit: df8e399c9bac2dc30d7cf69c2462a81729a3ae69 > > > Author: Justin Lecher gentoo org> > > > AuthorDate: Fri Oct 30 10:18:05 2015 +0000 > > > Commit: Justin Lecher gentoo org> > > > CommitDate: Fri Oct 30 12:03:49 2015 +0000 > > > URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3Ddf= 8e399c > > >=20 > > > eclass: Use consistent place for then in if clause =20 > >=20 > > Excuse me but who are you exactly to take a random eclass and commit > > random style changes inside without even bothering to contact > > the author? =20 >=20 > your attitude is wrong and is a great example of why people in the project > are hesitant to touch anything anymore >=20 > > > Signed-off-by: Justin Lecher gentoo.org> > > >=20 > > > eclass/distutils-r1.eclass | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > >=20 > > > diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass > > > index 185dd4f..dbd27a7 100644 > > > --- a/eclass/distutils-r1.eclass > > > +++ b/eclass/distutils-r1.eclass > > > @@ -322,8 +322,7 @@ distutils-r1_python_prepare_all() { > > > =20 > > > _distutils-r1_disable_ez_setup > > > =20 > > > - if [[ ${DISTUTILS_IN_SOURCE_BUILD} && ! ${DISTUTILS_SINGLE_IMPL} ]] > > > - then > > > + if [[ ${DISTUTILS_IN_SOURCE_BUILD} && ! ${DISTUTILS_SINGLE_IMPL} ]]= ; then =20 > >=20 > > This was intentionally wrapped to stay within 72-column line width. Not > > saying the eclass is perfect in keeping text width, especially with > > others committing random changes to it, but that's no reason to > > introduce further offenders. =20 >=20 > Gentoo has never had a hard 80-col rule let alone 72-cols. forcing a wrap > here makes no sense and the new version is an improvement. For years, Gentoo was unable to make *any* *sane* *global* rules. Which doesn't mean everything needs to be as crappy as the overall Gentoo 'quality'. So what's this improvement exactly? 'I like this style better, so it's an improvement'? As I see it, it's a pointless, changing-nothing-really commit that causes huge cache regen for no good reason except someone's fancy. --=20 Best regards, Micha=C5=82 G=C3=B3rny --Sig_/b+xKTZUonvvW02v9lGiqPH_ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJWNHcMXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ2REJCMDdDQzRGMERBRDA2RUEwQUZFNDFC MDdBMUFFQUVGQjQ0NjRFAAoJELB6GurvtEZO8jQP/A/2Z4FVqUuPVL+goDvck2Ls b7YP7mk/H6sjcXrY0aDfeNPLKuD9xaPn5lNhNLOj/K1JNncoOx+Swyu3TL+4dehp 1+fNTvOK02OXk99B7CzI8TfqrZUUzwou5VAz/LlGmv7DP4zTd1gZMJj4crk8uj76 h7pD8tqH0M98hmTRtHHBHdHqwcjCvX+NvTB7a/KB/1e47rMsM4JUS2+kSCXeaSBF kIBFegDhSgLanZNi+ucfDtIZPWDTwqxwNC88ARFHqdF9uo3vYtgU68BR9voR7l/r sDkUQigcNgnkvAfZASii2x47UoGcMK8Pkx43/x/XNnPN0KZwPwn8fD57Zq1tBFif bb21F9meMKfoavXYiEAaik17Kcs2B86G0MaoA3o+6Bubl1RKVBfzmyS8dOEBU3Wh mv1kAR42bqWi6q/syEKtAvTpEWkUmy4nZ+jbBc4T1uFgu7sk0qVnTBYx1gID8pHS JbqpGo0baiVjiFGRJ7mjGsTr7x7ViQNZKAWnuq86nzPnSRTs4kFFrew9xplDuzZU ZqB3/qhj1x6HBnmaCsoYCyxodJFKvXhh9vard8y5dnLNvimz8GOyRz2qkPHoMZ44 drzJU54PlacPfP8VjcOxvjfULxAWkVSsR0M+9jycQRp09GcLwZXLbOKa7CKEmUYZ 2iZ8iuSVK6EK3dBzgc1m =GO7M -----END PGP SIGNATURE----- --Sig_/b+xKTZUonvvW02v9lGiqPH_--