From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id D9FB613888F for ; Sat, 31 Oct 2015 07:06:31 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id F0D11E0835; Sat, 31 Oct 2015 07:06:23 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id B9ED6E07FC for ; Sat, 31 Oct 2015 07:06:22 +0000 (UTC) Received: from vapier.lan (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id DBF1C340B2B; Sat, 31 Oct 2015 07:06:21 +0000 (UTC) Date: Sat, 31 Oct 2015 03:06:21 -0400 From: Mike Frysinger To: gentoo-dev@lists.gentoo.org Cc: Justin Lecher Subject: Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/ Message-ID: <20151031070621.GO5154@vapier.lan> Mail-Followup-To: gentoo-dev@lists.gentoo.org, Justin Lecher References: <1446206629.df8e399c9bac2dc30d7cf69c2462a81729a3ae69.jlec@gentoo> <20151030182008.44e0c324.mgorny@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xTKfHyrFnSV9DG3y" Content-Disposition: inline In-Reply-To: <20151030182008.44e0c324.mgorny@gentoo.org> X-Archives-Salt: 106d6d89-ee1c-4f85-92b4-35627aa09b4e X-Archives-Hash: e54d09b0d33a564edc0e5de476ebc51f --xTKfHyrFnSV9DG3y Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 30 Oct 2015 18:20, Micha=C5=82 G=C3=B3rny wrote: > On Fri, 30 Oct 2015 12:03:59 +0000 (UTC) "Justin Lecher" wrote: > > commit: df8e399c9bac2dc30d7cf69c2462a81729a3ae69 > > Author: Justin Lecher gentoo org> > > AuthorDate: Fri Oct 30 10:18:05 2015 +0000 > > Commit: Justin Lecher gentoo org> > > CommitDate: Fri Oct 30 12:03:49 2015 +0000 > > URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3Ddf8e= 399c > >=20 > > eclass: Use consistent place for then in if clause >=20 > Excuse me but who are you exactly to take a random eclass and commit > random style changes inside without even bothering to contact > the author? your attitude is wrong and is a great example of why people in the project are hesitant to touch anything anymore > > Signed-off-by: Justin Lecher gentoo.org> > >=20 > > eclass/distutils-r1.eclass | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > >=20 > > diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass > > index 185dd4f..dbd27a7 100644 > > --- a/eclass/distutils-r1.eclass > > +++ b/eclass/distutils-r1.eclass > > @@ -322,8 +322,7 @@ distutils-r1_python_prepare_all() { > > =20 > > _distutils-r1_disable_ez_setup > > =20 > > - if [[ ${DISTUTILS_IN_SOURCE_BUILD} && ! ${DISTUTILS_SINGLE_IMPL} ]] > > - then > > + if [[ ${DISTUTILS_IN_SOURCE_BUILD} && ! ${DISTUTILS_SINGLE_IMPL} ]]; = then >=20 > This was intentionally wrapped to stay within 72-column line width. Not > saying the eclass is perfect in keeping text width, especially with > others committing random changes to it, but that's no reason to > introduce further offenders. Gentoo has never had a hard 80-col rule let alone 72-cols. forcing a wrap here makes no sense and the new version is an improvement. -mike --xTKfHyrFnSV9DG3y Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWNGhtAAoJEEFjO5/oN/WBeS4P/2lAw6iZwzrv1Xd2NsYumys8 RpUSz2O1HAuamEuRTv/uHCTmWhNP3lobNGnzrcTohtUuTWopFTf1XRX84zzsft/W OJ0SnHiJO+5p8/xVbhVYGNwKcWxQ7HG7NUZoWvUhxhyj+C44+cHL829XQl9o9jl6 p3WTHFOH5AssBAx19EvS5OKwr35k1R3wlXT7EM6ceD2ywHAT/dmzdAYH9oRRIlhe ZSX2m5zHVepq9q7uPVksBCq5u3s2K6y9h7FXs30cY+tL7njKl4zLe3sGrKh2xBVt sUIBghAVO7ngJWcw0YkmpBJzeOi2nR+rDGJLIjeWvNStb7W3EvRkp0ZGcUfcECY+ 8fdgqzHLTzBqJW+BpMmAwAKuWqLCvpB7FHlOE1XOYoGgGmtMR5jDLD+o6C2bzzLJ p8ccTJNyutbDadNUE5eKZf2i2ya16J4l+wxlWscjQnxpmeCDEhZMWzPKlONx7buD CEHXqMJ5yN2qmB3ATh3+IdE0A93mCnOIAT/gtRggjT5SCEzyPTj2WYIOPZea8JZY bMFcvy7MlYQ6PMttC2uxAi65es/LoLQtcdPd3cJnwiNu+y3k+KsO8UFmjQLXwhKl OEkkj9x+F0zohhTgm0YqBoUOYPvCOcu7laC6XMOcYMRSXfK0JYLB9DHbvv6Ey4Ar kKM0RpKr0FzMcXyd/PHT =W7HM -----END PGP SIGNATURE----- --xTKfHyrFnSV9DG3y--