From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 95CE613888F for ; Fri, 30 Oct 2015 17:20:35 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id A444B21C017; Fri, 30 Oct 2015 17:20:23 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id B7FFFE07FD for ; Fri, 30 Oct 2015 17:20:17 +0000 (UTC) Received: from pomiot (d202-251.icpnet.pl [109.173.202.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 875AA340CA5; Fri, 30 Oct 2015 17:20:14 +0000 (UTC) Date: Fri, 30 Oct 2015 18:20:08 +0100 From: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= To: "Justin Lecher" Cc: gentoo-dev@lists.gentoo.org Subject: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/ Message-ID: <20151030182008.44e0c324.mgorny@gentoo.org> In-Reply-To: <1446206629.df8e399c9bac2dc30d7cf69c2462a81729a3ae69.jlec@gentoo> References: <1446206629.df8e399c9bac2dc30d7cf69c2462a81729a3ae69.jlec@gentoo> Organization: Gentoo X-Mailer: Claws Mail 3.13.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/qeF.Jsaz_qUQ.hUPHp8VuMj"; protocol="application/pgp-signature" X-Archives-Salt: 5cbe15db-ea29-4777-8058-c5dfa7375a98 X-Archives-Hash: 1a45da21b1284a989a4e36017fe34037 --Sig_/qeF.Jsaz_qUQ.hUPHp8VuMj Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, 30 Oct 2015 12:03:59 +0000 (UTC) "Justin Lecher" wrote: > commit: df8e399c9bac2dc30d7cf69c2462a81729a3ae69 > Author: Justin Lecher gentoo org> > AuthorDate: Fri Oct 30 10:18:05 2015 +0000 > Commit: Justin Lecher gentoo org> > CommitDate: Fri Oct 30 12:03:49 2015 +0000 > URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3Ddf8e39= 9c >=20 > eclass: Use consistent place for then in if clause Excuse me but who are you exactly to take a random eclass and commit random style changes inside without even bothering to contact the author? Not to mention this commit message is incorrect as it doesn't state which eclass was modified. >=20 > Signed-off-by: Justin Lecher gentoo.org> >=20 > eclass/distutils-r1.eclass | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass > index 185dd4f..dbd27a7 100644 > --- a/eclass/distutils-r1.eclass > +++ b/eclass/distutils-r1.eclass > @@ -322,8 +322,7 @@ distutils-r1_python_prepare_all() { > =20 > _distutils-r1_disable_ez_setup > =20 > - if [[ ${DISTUTILS_IN_SOURCE_BUILD} && ! ${DISTUTILS_SINGLE_IMPL} ]] > - then > + if [[ ${DISTUTILS_IN_SOURCE_BUILD} && ! ${DISTUTILS_SINGLE_IMPL} ]]; th= en This was intentionally wrapped to stay within 72-column line width. Not saying the eclass is perfect in keeping text width, especially with others committing random changes to it, but that's no reason to introduce further offenders. > # create source copies for each implementation > python_copy_sources > fi >=20 --=20 Best regards, Micha=C5=82 G=C3=B3rny --Sig_/qeF.Jsaz_qUQ.hUPHp8VuMj Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJWM6bIXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ2REJCMDdDQzRGMERBRDA2RUEwQUZFNDFC MDdBMUFFQUVGQjQ0NjRFAAoJELB6GurvtEZOdw4QAMEOR8NMMhfya2fnvwhZh5Nn M+c5v84Y3rb42efGE15PGhbiEFIPmzp2RMIf7St4BIjkp5cZu1Ar/Wx1yNdilhrO Vo3ORS9N2at57yoAsaVWehp8zWKyhb3y4p3+LeAKaQRcbEBcjdvXRn2Av6yZvzfm OrGeYkILom+Rtvxryxpu5AsFNkxR0UjorMnOQl4wx97XLsAeReZZRpXhFoEfvQzX A6WaHl8QNvII4//0awjBA5UgPWvIh8k2Bnz47uiL0kq2TWfBkhvtaQs8F4zYfc0/ f8vlkCbOx1Jy4up7NbOyYDq7cycw2x/RGQ5wmEKvqr7VU0TUnSdxeub8pa5AGjm7 Cdqd0RJ/YBxnaF2+g2JLzbomdqg4qMMWNjYF0b7+6EvOWbkMLhHx0SonTiqnerTu UT9XZ9e8OP+mAT7ATcsAP6k37pEDlhy1haYo2wU6Zp2pXdgUZrzVBIjX+uX4+qGk 36KdK8N1xImUrsp67baRomc//Nh0LjXF2GjxmJpB6HpSnqgNTlrwziNKZ8QxCVW9 dlz9aRbJdt0XrV9x+MwvrZ+YlLzxb5pfegOXoQgEMMmfsCLCUC2a7j+q737RlKuz bfE1sGRvsGg6DnG7jsADKRZvjnkDQbiA6aOdC1t7ReL+EnM8VhnX0bQK28tU/vK5 SFIuB9YkjIrfZz4Lyak9 =pYIk -----END PGP SIGNATURE----- --Sig_/qeF.Jsaz_qUQ.hUPHp8VuMj--