[gentoo-dev] [PATCH] autotools.eclass: support AM_GNU_GETTEXT_REQUIRE_VERSION

[gentoo-dev] [PATCH] autotools.eclass: support AM_GNU_GETTEXT_REQUIRE_VERSION

[Michał Górny]

gettext 0.19.6 supports AM_GNU_GETTEXT_REQUIRE_VERSION in addition to
AM_GNU_GETTEXT_VERSION.
---
 eclass/autotools.eclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

// proxying this patch for Michał Bartoszkiewicz
// https://github.com/gentoo/gentoo/pull/163

diff --git a/eclass/autotools.eclass b/eclass/autotools.eclass
index bc4032a..3039a46 100644
--- a/eclass/autotools.eclass
+++ b/eclass/autotools.eclass
@@ -258,7 +258,7 @@ _at_uses_pkg() {
 }
 _at_uses_autoheader()  { _at_uses_pkg A{C,M}_CONFIG_HEADER{S,}; }
 _at_uses_automake()    { _at_uses_pkg AM_INIT_AUTOMAKE; }
-_at_uses_gettext()     { _at_uses_pkg AM_GNU_GETTEXT_VERSION; }
+_at_uses_gettext()     { _at_uses_pkg AM_GNU_GETTEXT_{,REQUIRE_}VERSION; }
 _at_uses_glibgettext() { _at_uses_pkg AM_GLIB_GNU_GETTEXT; }
 _at_uses_intltool()    { _at_uses_pkg {AC,IT}_PROG_INTLTOOL; }
 _at_uses_gtkdoc()      { _at_uses_pkg GTK_DOC_CHECK; }
@@ -531,7 +531,7 @@ ALL_AUTOTOOLS_MACROS=(
 	AC_CONFIG_AUX_DIR AC_CONFIG_MACRO_DIR
 	AM_INIT_AUTOMAKE
 	AM_GLIB_GNU_GETTEXT
-	AM_GNU_GETTEXT_VERSION
+	AM_GNU_GETTEXT_{,REQUIRE_}VERSION
 	{AC,IT}_PROG_INTLTOOL
 	GTK_DOC_CHECK
 	GNOME_DOC_INIT
-- 
2.6.1

[gentoo-dev] Re: [PATCH] autotools.eclass: support AM_GNU_GETTEXT_REQUIRE_VERSION

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 413 bytes --]

On 13 Oct 2015 18:25, Michał Górny wrote:
> gettext 0.19.6 supports AM_GNU_GETTEXT_REQUIRE_VERSION in addition to
> AM_GNU_GETTEXT_VERSION.

ok, although not entirely correct -- gettexize supports this, but autoreconf
does not.  we also send a patch to the autoconf project to update things.

> // proxying this patch for Michał Bartoszkiewicz

you should fix the --author of your commit then
-mike

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [gentoo-dev] Re: [PATCH] autotools.eclass: support AM_GNU_GETTEXT_REQUIRE_VERSION

[Michał Górny]

[-- Attachment #1: Type: text/plain, Size: 619 bytes --]

Dnia 2015-10-13, o godz. 15:13:45
Mike Frysinger <vapier@gentoo.org> napisał(a):

> On 13 Oct 2015 18:25, Michał Górny wrote:
> > gettext 0.19.6 supports AM_GNU_GETTEXT_REQUIRE_VERSION in addition to
> > AM_GNU_GETTEXT_VERSION.
> 
> ok, although not entirely correct -- gettexize supports this, but autoreconf
> does not.  we also send a patch to the autoconf project to update things.

I've sent the mail to autoconf-patches (even twice accidentally ;-)).

http://lists.gnu.org/archive/html/autoconf-patches/2015-10/msg00000.html

-- 
Best regards,
Michał Górny
<http://dev.gentoo.org/~mgorny/>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 949 bytes --]

Re: [gentoo-dev] [PATCH] autotools.eclass: support AM_GNU_GETTEXT_REQUIRE_VERSION

[Michał Górny]

[-- Attachment #1: Type: text/plain, Size: 321 bytes --]

Dnia 2015-10-13, o godz. 18:25:45
Michał Górny <mgorny@gentoo.org> napisał(a):

> gettext 0.19.6 supports AM_GNU_GETTEXT_REQUIRE_VERSION in addition to
> AM_GNU_GETTEXT_VERSION.

No negative replies for a few days. I've merged it merrily.

-- 
Best regards,
Michał Górny
<http://dev.gentoo.org/~mgorny/>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 949 bytes --]