From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 3CEA213888F for ; Fri, 9 Oct 2015 16:21:58 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 5DE3F21C029; Fri, 9 Oct 2015 16:21:46 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 5DFB421C013 for ; Fri, 9 Oct 2015 16:21:45 +0000 (UTC) Received: from localhost (AMontpellier-655-1-287-226.w81-251.abo.wanadoo.fr [81.251.59.226]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: aballier) by smtp.gentoo.org (Postfix) with ESMTPSA id A3A3E34070A for ; Fri, 9 Oct 2015 16:21:43 +0000 (UTC) Date: Fri, 9 Oct 2015 18:21:36 +0200 From: Alexis Ballier To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/ Message-ID: <20151009182136.251dc51e@gentoo.org> In-Reply-To: <5617DE06.5050200@gentoo.org> References: <1444389412.5220bb29741e1685b42a6312c0b7bf2821672040.aballier@gentoo> <5617DE06.5050200@gentoo.org> Organization: Gentoo X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Archives-Salt: a1010b45-3dfa-4574-948b-e7078c0eeda8 X-Archives-Hash: d481b952fd32990937ed54ea9be4ed7a On Fri, 9 Oct 2015 17:32:22 +0200 hasufell wrote: > On 10/09/2015 01:17 PM, Alexis Ballier wrote: > > commit: 5220bb29741e1685b42a6312c0b7bf2821672040 > > Author: Alexis Ballier gentoo org> > > AuthorDate: Fri Oct 9 11:16:38 2015 +0000 > > Commit: Alexis Ballier gentoo org> > > CommitDate: Fri Oct 9 11:16:52 2015 +0000 > > URL: > > https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5220bb29 > > > > eclass: ros-catkin.eclass: Use cmake-utils_src_make instead of > > plain emake for src_test so that it works with ninja too. > > > > > Please try to use short summary lines and put more detailed > description into the commit message after a newline, also see > https://wiki.gentoo.org/wiki/Gentoo_git_workflow#Example > > The prefix is also a bit uncommon, see > https://wiki.gentoo.org/wiki/Gentoo_git_workflow#Commit_message_format yeah, got that wrong; thx; i tried to remember it as '$dir: message', which works in all but this case it seems :) > Ofc, I will expect people to jump in and say "the council hasn't > decided on that yet", but well... it mostly works fine and is not > really controversial. not sure if council approval is needed; uniformity and consistency is way more important than whatever syntax is used