From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 3A05713881D for ; Sat, 26 Sep 2015 15:37:33 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 4F7E521C0B1; Sat, 26 Sep 2015 15:37:19 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 6FC0821C017 for ; Sat, 26 Sep 2015 15:37:18 +0000 (UTC) Received: from pomiot (77-253-137-92.adsl.inetia.pl [77.253.137.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 2346E340BC7; Sat, 26 Sep 2015 15:37:14 +0000 (UTC) Date: Sat, 26 Sep 2015 17:36:59 +0200 From: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= To: Alexis Ballier Cc: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCHES] git-r3.eclass: Slight cleanup and support for any ref Message-ID: <20150926173701.71f5946a.mgorny@gentoo.org> In-Reply-To: <20150926164414.74c34c5c@gentoo.org> References: <1443274139-3860-1-git-send-email-mgorny@gentoo.org> <20150926164414.74c34c5c@gentoo.org> Organization: Gentoo X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/_PLN5_R6NNMKY0maTI.bW8Q"; protocol="application/pgp-signature" X-Archives-Salt: 018ded12-331c-4a3a-b354-793ccf89d9b6 X-Archives-Hash: f2866032e967e55dbb365143c773948e --Sig_/_PLN5_R6NNMKY0maTI.bW8Q Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Dnia 2015-09-26, o godz. 16:44:14 Alexis Ballier napisa=C5=82(a): > On Sat, 26 Sep 2015 15:28:56 +0200 > Micha=C5=82 G=C3=B3rny wrote: >=20 > > Hi, > >=20 > > Small patch set for review. Patch 1 cleans up some comments inside > > the eclass, while patch 2 removes unused 'is_branch' variable. > > Finally, patch 3 adds support for passing any of the 'refs/*' rather > > than 'refs/heads/*' only. This was requested by vapier in #556822 [1]. >=20 > IMHO you don't need to send them for review here nor to create a > branch for committing these, esp. the cosmetics part :) >=20 > 3/3 will just increase what is fetched and might not break anything, > right ? I can't think of any case when it could break something. --=20 Best regards, Micha=C5=82 G=C3=B3rny --Sig_/_PLN5_R6NNMKY0maTI.bW8Q Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJWBrueXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ2REJCMDdDQzRGMERBRDA2RUEwQUZFNDFC MDdBMUFFQUVGQjQ0NjRFAAoJELB6GurvtEZOfs0QALlDD9QkshQHfLWWPVlVtxUU TJ83rIZSx+VV1j59e4ZVH+J2xZjJcgjwYhlVmBNCDj05AW1eE37ouKKU8R+MmqDp 6XPvjWU2RnrEDJJRQZ1hDLaD3qLIvGmZkBYshGreOfnwG+lfB7old0QlY4KjdkQn zWBQmfXvES1PQoe0kB9fHwHwVkkT7fBvQDO2iTbK0dvB+bdRYkImdBSaSyUmEz3T bBYF8hjtVkvrf7X9ts3mEf7JsNnwaxI7BKZZR0FD6xAM+hn4kkzCM0bTsgH7ZEOb IGdeOxUW2En2Cs3Wuiu4x4+yfQgwvqCrVMn9uEutcJldRafgwJQuRaJjG7LkX0o0 drB0CvxXcBoWAxFiF3G+0ZBjHfCHkVIQB74ao0fDYUDJ+NuMKKRV0jRD3KzKw26E YOfsFz7rItB4CLDxozHsXiPP+QVL8YlB8gEgPZ+7Fzhogim3oRbNI4z4u9SNdgky 4Db/4TDZk69zdiONzgZ6vdfhQVKgvxnBVfg7zcsT/ViRYQd0tXaWABr2hp1O5j44 t0pTc/smCj+gXBFpsWKjdPQY583wjkthh5nltdH6ZwiLT2lCkZxFDRaWE4/m8VBD hBnYoBsDqJIgoe1T+9JFkc9Buzl5Dpdi21jE3vWJragIi4zws8PRMNx3wKCgi5A1 tZycohybbAFDbPoseYFW =fxQO -----END PGP SIGNATURE----- --Sig_/_PLN5_R6NNMKY0maTI.bW8Q--