From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 54E5913881D for ; Sat, 26 Sep 2015 14:44:36 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id D8DF421C0A3; Sat, 26 Sep 2015 14:44:28 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id F2D7821C00A for ; Sat, 26 Sep 2015 14:44:27 +0000 (UTC) Received: from localhost (AMontpellier-655-1-324-208.w90-0.abo.wanadoo.fr [90.0.28.208]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: aballier) by smtp.gentoo.org (Postfix) with ESMTPSA id AF36333FFDD for ; Sat, 26 Sep 2015 14:44:25 +0000 (UTC) Date: Sat, 26 Sep 2015 16:44:14 +0200 From: Alexis Ballier To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCHES] git-r3.eclass: Slight cleanup and support for any ref Message-ID: <20150926164414.74c34c5c@gentoo.org> In-Reply-To: <1443274139-3860-1-git-send-email-mgorny@gentoo.org> References: <1443274139-3860-1-git-send-email-mgorny@gentoo.org> Organization: Gentoo X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: be292f2e-7a2a-4046-91c5-572b43de7733 X-Archives-Hash: f86c81e87eb922260efb4af43b5c7a67 On Sat, 26 Sep 2015 15:28:56 +0200 Micha=C5=82 G=C3=B3rny wrote: > Hi, >=20 > Small patch set for review. Patch 1 cleans up some comments inside > the eclass, while patch 2 removes unused 'is_branch' variable. > Finally, patch 3 adds support for passing any of the 'refs/*' rather > than 'refs/heads/*' only. This was requested by vapier in #556822 [1]. IMHO you don't need to send them for review here nor to create a branch for committing these, esp. the cosmetics part :) 3/3 will just increase what is fetched and might not break anything, right ?