From: Alexis Ballier <aballier@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCHES] git-r3.eclass: Slight cleanup and support for any ref
Date: Sat, 26 Sep 2015 16:44:14 +0200 [thread overview]
Message-ID: <20150926164414.74c34c5c@gentoo.org> (raw)
In-Reply-To: <1443274139-3860-1-git-send-email-mgorny@gentoo.org>
On Sat, 26 Sep 2015 15:28:56 +0200
Michał Górny <mgorny@gentoo.org> wrote:
> Hi,
>
> Small patch set for review. Patch 1 cleans up some comments inside
> the eclass, while patch 2 removes unused 'is_branch' variable.
> Finally, patch 3 adds support for passing any of the 'refs/*' rather
> than 'refs/heads/*' only. This was requested by vapier in #556822 [1].
IMHO you don't need to send them for review here nor to create a
branch for committing these, esp. the cosmetics part :)
3/3 will just increase what is fetched and might not break anything,
right ?
next prev parent reply other threads:[~2015-09-26 14:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-26 13:28 [gentoo-dev] [PATCHES] git-r3.eclass: Slight cleanup and support for any ref Michał Górny
2015-09-26 13:28 ` [gentoo-dev] [PATCH 1/3] git-r3.eclass: Improve the comments a bit Michał Górny
2015-09-26 13:28 ` [gentoo-dev] [PATCH 2/3] git-r3.eclass: Remove unused variable Michał Górny
2015-09-26 13:28 ` [gentoo-dev] [PATCH 3/3] git-r3.eclass: Accept any ref rather than refs/heads/* only Michał Górny
2015-09-26 14:44 ` Alexis Ballier [this message]
2015-09-26 15:36 ` [gentoo-dev] [PATCHES] git-r3.eclass: Slight cleanup and support for any ref Michał Górny
2015-11-29 10:04 ` Michał Górny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150926164414.74c34c5c@gentoo.org \
--to=aballier@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox