public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: James Le Cuirot <chewi@gentoo.org>
To: Fernando Rodriguez <frodriguez.developer@outlook.com>
Cc: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Github PR commenting policy
Date: Sun, 20 Sep 2015 23:33:34 +0100	[thread overview]
Message-ID: <20150920233334.542c2197@symphony.aura-online.co.uk> (raw)
In-Reply-To: <BLU436-SMTP1972880412411268080C53D8D470@phx.gbl>

[-- Attachment #1: Type: text/plain, Size: 1210 bytes --]

On Sun, 20 Sep 2015 17:53:25 -0400
Fernando Rodriguez <frodriguez.developer@outlook.com> wrote:

> On Saturday, September 19, 2015 7:31:11 AM Michał Górny wrote:
> > Dnia 2015-09-18, o godz. 20:09:16
> > Fernando Rodriguez <frodriguez.developer@outlook.com> napisał(a):
> > 
> > > Github allows editting of comments in pull requests. Is there a
> > > policy regarding that? I've noticed a comment disappear which
> > > makes the rest of the 
> > > conversation seem out of place.
> > 
> > We can't really do anything about that. However, we might soon be
> > mirroring all comments on Bugzilla where removing comments is not
> > permitted.
> 
> I realize you can't control how users use that feature but there
> should be some policy about how developers use it. I opened at PR
> because I was asked in bugzilla. I received some suggestions to which
> I replied that most of them are not related to my PR but will still
> do them. After I pushed the changes the comment making the
> suggestions gets deleted.

They are probably not deleted but merely hidden. There should be a
"Show outdated diff" link that will reveal them.

-- 
James Le Cuirot (chewi)
Gentoo Linux Developer

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 951 bytes --]

  reply	other threads:[~2015-09-20 22:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-19  0:09 [gentoo-dev] Github PR commenting policy Fernando Rodriguez
2015-09-19  5:31 ` Michał Górny
2015-09-20 21:53   ` Fernando Rodriguez
2015-09-20 22:33     ` James Le Cuirot [this message]
2015-09-20 22:54       ` Fernando Rodriguez
2015-09-20 23:00         ` James Le Cuirot
2015-09-20 23:53           ` Fernando Rodriguez
2015-10-19  8:05             ` [gentoo-dev] " selurvedu
2015-09-20  9:26 ` [gentoo-dev] " Jeroen Roovers
2015-09-20  9:33   ` Michał Górny
2015-09-20 10:17     ` Markos Chandras
2015-09-21 12:00   ` Alexander Berntsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150920233334.542c2197@symphony.aura-online.co.uk \
    --to=chewi@gentoo.org \
    --cc=frodriguez.developer@outlook.com \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox