Re: [gentoo-dev] Referencing bug reports in git (WAS: Re: [gentoo-commits] repo/gentoo:master commit in: sci-libs/opencascade/)

["Michał Górny" <mgorny@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 2023 bytes --]

Dnia 2015-08-09, o godz. 23:01:32
hasufell <hasufell@gentoo.org> napisał(a):

> On 08/09/2015 09:56 PM, Michał Górny wrote:
> > Dnia 2015-08-09, o godz. 16:09:29
> > hasufell <hasufell@gentoo.org> napisał(a):
> > 
> >> On 08/09/2015 03:58 PM, Michael Weber wrote:
> >>> commit:     40b3fd64ec9c5d6d94f0f0897740bc77622c24a1
> >>> Author:     Michael Weber <xmw <AT> gentoo <DOT> org>
> >>> AuthorDate: Sun Aug  9 13:58:26 2015 +0000
> >>> Commit:     Michael Weber <xmw <AT> gentoo <DOT> org>
> >>> CommitDate: Sun Aug  9 13:58:26 2015 +0000
> >>> URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=40b3fd64
> >>>
> >>> sci-libs/opencascade: add USE=vtk (bug 557022, thanks Helmut Jarausch).
> >>>
> >>
> >> I was wondering if we should set a standard for referencing bug reports.
> >> The portage team already does something like that:
> >> https://github.com/gentoo/portage/commit/b7149002bf23889f280c502afe6ceda0b1345ca3
> >>
> >> Following that, the commit could have been:
> >> =====
> >> sci-libs/opencascade: add USE=vtk
> >>
> >> thanks to Helmut Jarausch
> >>
> >> X-Gentoo-Bug: 557022
> >> X-Gentoo-Bug-url: https://bugs.gentoo.org/show_bug.cgi?id=557022
> >> =====
> > 
> > Which is terribly redundant. Just put the whole bug URL. Advantages:
> > 
> > - keeps the bug namespaced to bugs.gentoo.org,
> > - has the bug no inside,
> > - is convenient -- you can click it instead of copy-pasting the no.
> > 
> > Also there are some standard keywords that are sometimes used to
> > reference bugs, like 'Fixes:' used by x.org.
> > 
> 
> I am not sure what exactly you do propose.

Fixes: https://bugs.gentoo.org/show_bug.cgi?id=557022
References: https://bugs.gentoo.org/show_bug.cgi?id=557022
X-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=557022
Whatever: https://bugs.gentoo.org/show_bug.cgi?id=557022

Just no magical numbers which are meaningless without the context.

-- 
Best regards,
Michał Górny
<http://dev.gentoo.org/~mgorny/>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 949 bytes --]