[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: ChangeLog kde5.eclass

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: ChangeLog kde5.eclass

[Michał Górny]

[-- Attachment #1: Type: text/plain, Size: 1600 bytes --]

Dnia 2015-05-09, o godz. 10:22:36
"Manuel Rueger (mrueg)" <mrueg@gentoo.org> napisał(a):

> mrueg       15/05/09 10:22:36
> 
>   Modified:             ChangeLog kde5.eclass
>   Log:
>   Sync kde5.eclass with overlay.
> 
> Revision  Changes    Path
> 1.1604               eclass/ChangeLog
> 
> file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/ChangeLog?rev=1.1604&view=markup
> plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/ChangeLog?rev=1.1604&content-type=text/plain
> diff : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/ChangeLog?r1=1.1603&r2=1.1604
> 
> Index: ChangeLog
> ===================================================================
> RCS file: /var/cvsroot/gentoo-x86/eclass/ChangeLog,v
> retrieving revision 1.1603
> retrieving revision 1.1604
> diff -u -r1.1603 -r1.1604
> --- ChangeLog	9 May 2015 08:01:28 -0000	1.1603
> +++ ChangeLog	9 May 2015 10:22:36 -0000	1.1604
> @@ -1,6 +1,9 @@
>  # ChangeLog for eclass directory
>  # Copyright 1999-2015 Gentoo Foundation; Distributed under the GPL v2
> -# $Header: /var/cvsroot/gentoo-x86/eclass/ChangeLog,v 1.1603 2015/05/09 08:01:28 ulm Exp $
> +# $Header: /var/cvsroot/gentoo-x86/eclass/ChangeLog,v 1.1604 2015/05/09 10:22:36 mrueg Exp $
> +
> +  09 May 2015; Manuel Rüger <mrueg@gentoo.org> kde5.eclass:
> +  Sync with overlay.

This isn't a really useful ChangeLog note (commit message), you know?
Describe *what* you change, do not expect users to go try to figure out
where the overlay is and which changes you merged.

-- 
Best regards,
Michał Górny

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 949 bytes --]

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: ChangeLog kde5.eclass

[Jeroen Roovers]

On Sun, 10 May 2015 06:44:30 +0200
Michał Górny <mgorny@gentoo.org> wrote:

> > +  09 May 2015; Manuel Rüger <mrueg@gentoo.org> kde5.eclass:
> > +  Sync with overlay.
> 
> This isn't a really useful ChangeLog note (commit message), you know?
> Describe *what* you change, do not expect users to go try to figure
> out where the overlay is and which changes you merged.

Nothing positive happened yet to the ChangeLog entry. Instead we got
more.

  15 May 2015; Michael Palimaka <kensington@gentoo.org>
  kde4-base.eclass: Sync with KDE overlay - update SRC_URI.

Hi KDE people, you can fix ChangeLog entries. So now you know.


     jer

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: ChangeLog kde5.eclass

[Michael Palimaka]

On 17/05/15 06:04, Jeroen Roovers wrote:
> On Sun, 10 May 2015 06:44:30 +0200
> Michał Górny <mgorny@gentoo.org> wrote:
> 
>>> +  09 May 2015; Manuel Rüger <mrueg@gentoo.org> kde5.eclass:
>>> +  Sync with overlay.
>>
>> This isn't a really useful ChangeLog note (commit message), you know?
>> Describe *what* you change, do not expect users to go try to figure
>> out where the overlay is and which changes you merged.
> 
> Nothing positive happened yet to the ChangeLog entry. Instead we got
> more.
> 
>   15 May 2015; Michael Palimaka <kensington@gentoo.org>
>   kde4-base.eclass: Sync with KDE overlay - update SRC_URI.
> 

This is a complete description of the changes made.

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: ChangeLog kde5.eclass

[Jeroen Roovers]

On Sun, 17 May 2015 06:08:56 +1000
Michael Palimaka <kensington@gentoo.org> wrote:

> >   15 May 2015; Michael Palimaka <kensington@gentoo.org>
> >   kde4-base.eclass: Sync with KDE overlay - update SRC_URI.
> > 
> 
> This is a complete description of the changes made.

OK, then that dash should be interpreted as an em dash, I guess, and
"Sync with KDE overlay" is a development note intended for that overlay
(yeah, we downstreamed that!) that accidentally slipped into the main
tree, adding nothing useful.


      jer

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: ChangeLog kde5.eclass

[hasufell]

On 05/17/2015 10:16 AM, Jeroen Roovers wrote:
> On Sun, 17 May 2015 06:08:56 +1000
> Michael Palimaka <kensington@gentoo.org> wrote:
> 
>>>   15 May 2015; Michael Palimaka <kensington@gentoo.org>
>>>   kde4-base.eclass: Sync with KDE overlay - update SRC_URI.
>>>
>>
>> This is a complete description of the changes made.
> 
> OK, then that dash should be interpreted as an em dash, I guess, and
> "Sync with KDE overlay" is a development note intended for that overlay
> (yeah, we downstreamed that!) that accidentally slipped into the main
> tree, adding nothing useful.
> 
> 
>       jer
> 

That is a limitation of CVS not being able to do actual merges. I'd say
it's debatable whether "merge information" should be manually added to
the ChangeLog entry. I think it can be left to the maintainer.

The problem is only with those earliers ChangeLog entries that ONLY have
that "merge information".

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: ChangeLog kde5.eclass

[Alexis Ballier]

On Sun, 17 May 2015 13:45:32 +0200
hasufell <hasufell@gentoo.org> wrote:

> On 05/17/2015 10:16 AM, Jeroen Roovers wrote:
> > On Sun, 17 May 2015 06:08:56 +1000
> > Michael Palimaka <kensington@gentoo.org> wrote:
> > 
> >>>   15 May 2015; Michael Palimaka <kensington@gentoo.org>
> >>>   kde4-base.eclass: Sync with KDE overlay - update SRC_URI.
> >>>
> >>
> >> This is a complete description of the changes made.
> > 
> > OK, then that dash should be interpreted as an em dash, I guess, and
> > "Sync with KDE overlay" is a development note intended for that
> > overlay (yeah, we downstreamed that!) that accidentally slipped
> > into the main tree, adding nothing useful.
> > 
> > 
> >       jer
> > 
> 
> That is a limitation of CVS 

Use mgorny's pull request framework if you can't properly use CVS.
Somehow it manages to get it right and also happens to commit to CVS...

> not being able to do actual merges. I'd
> say it's debatable whether "merge information" should be manually
> added to the ChangeLog entry. I think it can be left to the
> maintainer.

https://devmanual.gentoo.org/ebuild-writing/misc-files/changelog/index.html#writing-correct-changelog-messages