[gentoo-dev] ELT-patches from overlay?

[gentoo-dev] ELT-patches from overlay?

[Benda Xu]

Hi,

In libtool.eclass[1], it is mentioned in the comments of elt_patch_dir()
that

# If an overlay has eclass overrides, but doesn't actually override the
# libtool.eclass, we'll have ECLASSDIR pointing to the active overlay's
# eclass/ dir, but libtool.eclass is still in the main Gentoo tree.  So
# add a check to locate the ELT-patches/ regardless of what's going on.


But quoting from PMS[2], "ECLASSDIR: The full path to the master
repository’s eclass directory", ECLASSDIR always points to
${PORTDIR}/eclass, regardless how the repos.conf is configured.


Thus as long as ELT-patches dir of the gx86 tree exists, there is no way
to tell libtool.eclass to use it in my overlay.

Do I have to hack libtool.eclass?

Cheers,
Benda

1. https://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/eclass/libtool.eclass
2. https://dev.gentoo.org/~ulm/pms/head/pms.html

Re: [gentoo-dev] ELT-patches from overlay?

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 1319 bytes --]

On 11 May 2015 22:44, Benda Xu wrote:
> In libtool.eclass[1], it is mentioned in the comments of elt_patch_dir()
> that
> 
> # If an overlay has eclass overrides, but doesn't actually override the
> # libtool.eclass, we'll have ECLASSDIR pointing to the active overlay's
> # eclass/ dir, but libtool.eclass is still in the main Gentoo tree.  So
> # add a check to locate the ELT-patches/ regardless of what's going on.
> 
> 
> But quoting from PMS[2], "ECLASSDIR: The full path to the master
> repository’s eclass directory", ECLASSDIR always points to
> ${PORTDIR}/eclass, regardless how the repos.conf is configured.
> 
> 
> Thus as long as ELT-patches dir of the gx86 tree exists, there is no way
> to tell libtool.eclass to use it in my overlay.

that's the point of the change -- to locate ELT-patches that matches the 
libtool.eclass regardless of what the overlay is doing.  the intention was not 
to support local sets of ELT-patches while still using the libtool.eclass from 
elsewhere.  see the bug referenced in the commit:
	https://bugs.gentoo.org/389009

if you duplicate libtool.eclass in your overlay, it should find ELT-patches 
there.  considering libtool.eclass is pretty tightly coupled to the contents of 
that dir, i'm not sure supporting overlays is desirable.
-mike

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]