public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] ELT-patches from overlay?
Date: Tue, 12 May 2015 11:34:32 -0400	[thread overview]
Message-ID: <20150512153432.GB22975@vapier> (raw)
In-Reply-To: <861tinut3c.fsf@moguhome00.in.awa.tohoku.ac.jp>

[-- Attachment #1: Type: text/plain, Size: 1319 bytes --]

On 11 May 2015 22:44, Benda Xu wrote:
> In libtool.eclass[1], it is mentioned in the comments of elt_patch_dir()
> that
> 
> # If an overlay has eclass overrides, but doesn't actually override the
> # libtool.eclass, we'll have ECLASSDIR pointing to the active overlay's
> # eclass/ dir, but libtool.eclass is still in the main Gentoo tree.  So
> # add a check to locate the ELT-patches/ regardless of what's going on.
> 
> 
> But quoting from PMS[2], "ECLASSDIR: The full path to the master
> repository’s eclass directory", ECLASSDIR always points to
> ${PORTDIR}/eclass, regardless how the repos.conf is configured.
> 
> 
> Thus as long as ELT-patches dir of the gx86 tree exists, there is no way
> to tell libtool.eclass to use it in my overlay.

that's the point of the change -- to locate ELT-patches that matches the 
libtool.eclass regardless of what the overlay is doing.  the intention was not 
to support local sets of ELT-patches while still using the libtool.eclass from 
elsewhere.  see the bug referenced in the commit:
	https://bugs.gentoo.org/389009

if you duplicate libtool.eclass in your overlay, it should find ELT-patches 
there.  considering libtool.eclass is pretty tightly coupled to the contents of 
that dir, i'm not sure supporting overlays is desirable.
-mike

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

      reply	other threads:[~2015-05-12 15:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-11 13:44 [gentoo-dev] ELT-patches from overlay? Benda Xu
2015-05-12 15:34 ` Mike Frysinger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150512153432.GB22975@vapier \
    --to=vapier@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox