[gentoo-dev] Perl cleanups, the next level

[gentoo-dev] Perl cleanups, the next level

[Andreas K. Huettel]

[-- Attachment #1: Type: Text/Plain, Size: 1812 bytes --]


TL;DR: perl-module.eclass gets a well-defined and documented API. You may see 
some harmless "eqawarn" warnings from your ebuilds over the next time; either 
fix them yourself according to the warning message or just wait until the 
warnings are gone again. Overlay ebuilds will need to be fixed.


Hi all, 

perl-module.eclass has grown over the years. While it contains a lot of 
functionality, there are also several duplicate functions and many unneeded 
phase definitions. [And other complications as e.g. abysmal *FLAGS handling, 
but that's a story for another christmas^H^H^H^H^H^H^H^H EAPI.] So, it's 
cleanup time. 

What will NOT happen: The list of *exported* phase functions will NOT change 
now. That's reserved for future EAPIs, e.g. for the EAPI=6 transition. So, you 
can be safe that inheritance order etc bla bla remains unchanged.

What will happen: 
* Addition of documentation
* Removal of duplicate functions (e.g., "perlinfo" does exactly the same as 
"perl_set_version")
* Removal of not-exported, pointless phase functions (e.g., "perl-
module_pkg_preinst" is not exported and calls only "perl_set_version" - so a 
call of "perl-module_pkg_preinst" can be replaced by a call of 
"perl_set_version").

The changes to the eclass themselves are in these steps trivial and (in my 
opinion) do not merit review outside the Perl team. [Protest if you think 
otherwise.] The proposed workflow would be
* add eqawarn to duplicate, about to be removed function, add docs
* fix all ebuilds in the main tree (me, perl team, anyone; roughly 100 commits 
I'd guess)
* change eqawarn to eerror
* remove duplicate function some time later

Cheers, 
Andreas

-- 

Andreas K. Huettel
Gentoo Linux developer 
dilfridge@gentoo.org
http://www.akhuettel.de/


[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 951 bytes --]