From: "Michał Górny" <mgorny@gentoo.org>
To: Davide Pesavento <pesa@gentoo.org>
Cc: gentoo-dev@lists.gentoo.org, hasufell@gentoo.org
Subject: Re: [gentoo-dev] [PATCH 2/2] multilib-minimal.eclass: use run_in_build_dir().
Date: Thu, 23 Oct 2014 23:08:54 +0200 [thread overview]
Message-ID: <20141023230854.6375d7f7@pomiot.lan> (raw)
In-Reply-To: <CADfzvvaEXOQHA61_B2G49OqY1+FZYq7ugUx4SGFii0LsdMT3uQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1113 bytes --]
Dnia 2014-10-23, o godz. 22:31:39
Davide Pesavento <pesa@gentoo.org> napisał(a):
> Index: multilib-minimal.eclass
> ===================================================================
> RCS file: /var/cvsroot/gentoo-x86/eclass/multilib-minimal.eclass,v
> retrieving revision 1.9
> diff -u -r1.9 multilib-minimal.eclass
> --- multilib-minimal.eclass 2 May 2014 16:16:37 -0000 1.9
> +++ multilib-minimal.eclass 23 Oct 2014 20:24:23 -0000
> @@ -30,7 +30,7 @@
> esac
>
>
> -inherit eutils multilib-build
> +inherit eutils multibuild multilib-build
>
> EXPORT_FUNCTIONS src_configure src_compile src_test src_install
>
> @@ -41,17 +41,14 @@
> multilib-minimal_abi_src_configure() {
> debug-print-function ${FUNCNAME} "$@"
>
> - mkdir -p "${BUILD_DIR}" || die
> - pushd "${BUILD_DIR}" >/dev/null || die
> if declare -f multilib_src_configure >/dev/null ; then
> multilib_src_configure
> else
> default_src_configure
> fi
> - popd >/dev/null || die
NAK. No real gain in this, while indirection makes the eclass harder to
read.
--
Best regards,
Michał Górny
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 949 bytes --]
next prev parent reply other threads:[~2014-10-23 21:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 20:31 [gentoo-dev] [PATCH 2/2] multilib-minimal.eclass: use run_in_build_dir() Davide Pesavento
2014-10-23 21:08 ` Michał Górny [this message]
2014-10-31 1:06 ` Davide Pesavento
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141023230854.6375d7f7@pomiot.lan \
--to=mgorny@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=hasufell@gentoo.org \
--cc=pesa@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox