From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <gentoo-dev+bounces-67290-garchives=archives.gentoo.org@lists.gentoo.org> Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 7059313877A for <garchives@archives.gentoo.org>; Mon, 18 Aug 2014 12:52:18 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id EC5ACE0B05; Mon, 18 Aug 2014 12:52:12 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id E44E0E0AC5 for <gentoo-dev@lists.gentoo.org>; Mon, 18 Aug 2014 12:52:11 +0000 (UTC) Received: from pomiot.lan (77-254-95-248.adsl.inetia.pl [77.254.95.248]) (using SSLv3 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id D000234006B; Mon, 18 Aug 2014 12:52:09 +0000 (UTC) Date: Mon, 18 Aug 2014 14:52:59 +0200 From: =?ISO-8859-2?B?TWljaGGzIEfzcm55?= <mgorny@gentoo.org> To: hasufell <hasufell@gentoo.org> Cc: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] rfc: calling all eclass phase functions by default Message-ID: <20140818145259.0087116f@pomiot.lan> In-Reply-To: <53F1F467.80508@gentoo.org> References: <20140816215428.GA6773@linux1> <53F1BF3C.9060902@gentoo.org> <53F1EBE7.6090700@gentoo.org> <53F1EF49.9030503@gentoo.org> <53F1F1EB.6030601@gentoo.org> <53F1F467.80508@gentoo.org> Organization: Gentoo X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.24; x86_64-pc-linux-gnu) Precedence: bulk List-Post: <mailto:gentoo-dev@lists.gentoo.org> List-Help: <mailto:gentoo-dev+help@lists.gentoo.org> List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org> List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org> List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org> X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/xIw5Fs86Y/XB0EaRYXIuTGk"; protocol="application/pgp-signature" X-Archives-Salt: cc1e83ec-1d43-4b99-8234-bd46c27eba1c X-Archives-Hash: 1557750fab6cd52610946399a6a94df3 --Sig_/xIw5Fs86Y/XB0EaRYXIuTGk Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Dnia 2014-08-18, o godz. 12:41:11 hasufell <hasufell@gentoo.org> napisa=C5=82(a): > hasufell: > > Sergey Popov: > >> 18.08.2014 16:04, hasufell =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > >>>> You have my strong opposition on such change as well. It will turn > >>>> ebuilds into unreadable and undpredictable mess, please do not do th= at > >>>> > >>> > >>> They are already fairly unreadable and unpredictable. > >>> > >> > >> For you - maybe. But not for me. > >> > >> I am NOT talking about hacks like putting additional *.as files through > >> echo(hello Boost ebuild) or doing something crazy with subshells. > >> > >> But most of the eclass and ebuilds are readable quite simple if you re= ad > >> devmanual, PMS and have a brain. > >> > >> Of course, there are sometimes non-trivial stuff that is hard to read. > >> > >> But majority of ebuilds and eclasses are fine to understand and predic= t. > >> > >> So, without examples from you, this discussion will lead to nowhere, s= o, > >> please let's stop it. > >> > >=20 > > From my time as a sunrise dev I strongly disagree. People have problems > > with understanding the mess, including actual programmers. They have > > enough technical understanding, but not the time or motivation to go > > through all those funny pitfalls which are NOT properly documented in > > devmanual. > >=20 > > The most popular example is what we are talking about right now: > > indirect inheritance for example via games.eclass which inherits > > base.eclass but does not export src_unpack so stuff like unpacker.eclass > > and git-2.eclass will likely just do nothing if you inherit them before > > games.eclass (which is required by games herd policy)... uhm. I doubt > > you would have guessed this one if you saw the plain ebuild. I know the > > pitfall, so I see it just from looking at the inherit line. But it is > > far from being obvious. > >=20 >=20 > Even more interesting... you can work around this by inheriting > base.eclass explicitly before e.g. unpacker.eclass, something like >=20 > inherit base unpacker games This is a bug with vapier's approach at spanking and will be fixed. --=20 Best regards, Micha=C5=82 G=C3=B3rny --Sig_/xIw5Fs86Y/XB0EaRYXIuTGk Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJT8fcrXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ2REJCMDdDQzRGMERBRDA2RUEwQUZFNDFC MDdBMUFFQUVGQjQ0NjRFAAoJELB6GurvtEZO/nIQAMsrzGHgvH8XsaMK185zHWqX WoUdmEjOLljPG7RlGeK+xgJKMjT6owpaPJu0sImvLbYK0tDo1Hxjus7mIoN4Hg1Y yq80Mo0HJ36EAIT5oscBebmsYvj38FujDhF7Zt4JkokqL6871F1JPS8SZ6U992Pt yCQHA3tlSskRDuMGMxxM6f3oRtSZTYBb2XcG72dROdDnx6LrtLm+EpcoWHa/kV3P NKEVel0dCAf5HT3IGtgU9ILO5socx7Qtc/A4YQuXcLd7At8YpgHCr3VRo60JeWYN OI9KraIrZVu+y1NNKn1CeOOdhPlVZ23Q2i73X7T3+qKPdNT4Lp0lXdxEHgkOwcGL pcEWzFstM6ZowCoGlpWm3jR26YdEZ1wKAt45QT/nFiSMXqA0eqpXwaGcNjD+q9Fi lsr2ScJmdL/LZADJU8L9XQeASAOs0ISRaJavNr04F3246CnS/USKPqKr15PYpLLk EeaEtE8ZcSXWg0oWehdZRiJl+1OScUrMXrGpPyLloJsWgZVbadNfKwFF415xg/Vg sEXlN3Nte+3REU6wbqa1ZlZWskIqkk5dPb+8IbmgQIG4hrsqJUtz1/eG7PDC/lae el7UaXQG47AkfzI3EEqRYX8p8VV6Utuee3uN8/52AOLwJtUGaUHcU2yqrHmTGyDX dVEllWnaCySOgX8YJqZ1 =7tvn -----END PGP SIGNATURE----- --Sig_/xIw5Fs86Y/XB0EaRYXIuTGk--