From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id EDCB213877A for ; Sun, 17 Aug 2014 07:17:51 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 9FEE9E0959; Sun, 17 Aug 2014 07:17:46 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id A5855E093D for ; Sun, 17 Aug 2014 07:17:45 +0000 (UTC) Received: from pomiot.lan (77-254-95-248.adsl.inetia.pl [77.254.95.248]) (using SSLv3 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 764793400A2; Sun, 17 Aug 2014 07:17:43 +0000 (UTC) Date: Sun, 17 Aug 2014 09:18:29 +0200 From: =?ISO-8859-2?B?TWljaGGzIEfzcm55?= To: "=?ISO-8859-2?B?UGF3ZbM=?= Hajdan, Jr." Cc: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] rfc: calling all eclass phase functions by default Message-ID: <20140817091829.59b2e3da@pomiot.lan> In-Reply-To: <53F0545C.907@gentoo.org> References: <20140816215428.GA6773@linux1> <53F0545C.907@gentoo.org> Organization: Gentoo X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.24; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/x2K3CRWKFwSOtqtr=i=1KoT"; protocol="application/pgp-signature" X-Archives-Salt: d52b0659-a6ae-42ef-8088-db0279bbbc4b X-Archives-Hash: 6672718394e4bf0424aa9892e4e9b9bc --Sig_/x2K3CRWKFwSOtqtr=i=1KoT Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: quoted-printable Dnia 2014-08-17, o godz. 09:06:04 "Pawe=B3 Hajdan, Jr." napisa=B3(a): > On 8/17/14, 12:32 AM, Kent Fredric wrote: > > Collison systems I've seen usually do one of two things: > >=20 > > - In the event of a collision, demand the consumer resolve the problem = by > > redefining the function the collision occurs on in terms of its composi= te > > parts. ( which is basically what we already do ) > > - Declare syntax to "exclude" a potential collision from either composi= te > > part. > >=20 > > Our only real difference at present is unlike these systems, we assume = we > > can simply guess which one wins and just choose it automatically, where > > collision systems tend to force you to deal with the situation if any > > collision occurs. >=20 > This makes sense to me. Can we consider starting with just a repoman > warning for the collision cases? Not really. First, you have to run a policy that prohibits solving them through inherit order through QA. And saying for myself, I doubt I would vote for a proposal which forces me to write more ebuild code. Once QA agrees on a policy, we can add a matching repoman check. Otherwise, it's full of false positives and a topic of bikeshed, and then it is reverted. > The warning would make the problem more visible to ebuild writers. Then > we already have a solution that works, i.e. explicitly defining the > phase function in the ebuild, possibly calling the eclass functions. >=20 > My understanding is people not being aware of the problem is the main > issue here, not the ability to address it. What we could do is printing the phase function names when starting them, e.g.: >>> [foo_src_compile] Compiling sources in ... As for another idea, we could warn if an eclass overrides phase function via implicit inherit without redefining it. As I see it, this is the biggest issue here, and a solution that's relatively easy to accept. --=20 Best regards, Micha=B3 G=F3rny --Sig_/x2K3CRWKFwSOtqtr=i=1KoT Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJT8FdFXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ2REJCMDdDQzRGMERBRDA2RUEwQUZFNDFC MDdBMUFFQUVGQjQ0NjRFAAoJELB6GurvtEZO69oP/0QA3AvmSxIR4ogbzy6Lh7/A hGss5do+L8+BEuGe2F/9SFfRzRP9hMplRGK5DWb3PL1i7mVBBvyKJGJlGn6bEzsQ G2Q8aexlzC9tQEKg5vP93SNtl6Pgkjzin2+V4C2PAGC4dd4vfLSrPCDgWZJr12nh ChtTD8hvd586BOY2Vaq5rbY7iIkyvYhduQ02jH5Vqida36YHCGNnsM332vv0Gezb NDe2S4TFMBIyLEnOijAvbdkfnr5rbMw1P57Lyw1hf83CMKKa2UDLk5otngq95T6p hmIEvyNQnyrExn0n9yzxlUYPI/WZWgbrY9hDBkezVh8YWg0f2Mn9sk2HhNcikCPY tGitxkg8fgTbC6A7YOB4Yh8LkU8ps60NPZAWWjdmFiH2zPdBuMe6SGlRnUxCrjXf h/Y2pz3eGtGdMLObxml1W+n20op8FU0w5W6gsMjUQfIZpbmdJQAd3TuQE/hK1af7 Fs1tF60vNWVj9+Hs+yQj+/ZAkMebLKvs0HfRfEeTxLK3uG/Jej03NeSMFEuy34Vh 1lt5B0pmZqIltketOYBDTM98eqvJ8Rk9Kmi74STy5hAxgFjxdsHGg5CXdQete4DQ rmlNS6WIY5N1N6A7viknTUlS7xs6D+MlEZuLDVS4td9hQY8Vf1rFjGaA6B/XOMaN U8ewBqqJpSXSf++lAeY5 =BEVA -----END PGP SIGNATURE----- --Sig_/x2K3CRWKFwSOtqtr=i=1KoT--