From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <gentoo-dev+bounces-67229-garchives=archives.gentoo.org@lists.gentoo.org> Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id ACC1513877A for <garchives@archives.gentoo.org>; Tue, 12 Aug 2014 18:45:42 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id BC619E0D0F; Tue, 12 Aug 2014 18:45:38 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id D051DE0CFA for <gentoo-dev@lists.gentoo.org>; Tue, 12 Aug 2014 18:45:37 +0000 (UTC) Received: from pomiot.lan (77-254-95-248.adsl.inetia.pl [77.254.95.248]) (using SSLv3 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 051F334050A; Tue, 12 Aug 2014 18:45:35 +0000 (UTC) Date: Tue, 12 Aug 2014 20:46:14 +0200 From: =?ISO-8859-2?B?TWljaGGzIEfzcm55?= <mgorny@gentoo.org> To: William Hubbs <williamh@gentoo.org> Cc: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] gentoo-x86 tree cleanup for 'DESCRIPTION ends with a '.' character' warnings Message-ID: <20140812204614.1b9be84d@pomiot.lan> In-Reply-To: <20140812014820.GA3086@linux1> References: <20140810152211.2cc5ae94@sf> <20140812014820.GA3086@linux1> Organization: Gentoo X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.24; x86_64-pc-linux-gnu) Precedence: bulk List-Post: <mailto:gentoo-dev@lists.gentoo.org> List-Help: <mailto:gentoo-dev+help@lists.gentoo.org> List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org> List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org> List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org> X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/4Wzh1hJUmi3h=v7CNsXO8Ia"; protocol="application/pgp-signature" X-Archives-Salt: dfad1840-ed7d-472f-b875-0abf959c4987 X-Archives-Hash: 390ec83f00352e5e80c0984ca9c0ca14 --Sig_/4Wzh1hJUmi3h=v7CNsXO8Ia Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: quoted-printable Dnia 2014-08-11, o godz. 20:48:20 William Hubbs <williamh@gentoo.org> napisa=B3(a): > On Sun, Aug 10, 2014 at 03:22:11PM +0300, Sergei Trofimovich wrote: > > Hello World! > >=20 > > TL;DR: > > This evening I plan to mangle ~3000 ebuilds in the main tree > > by dropping trailing '.' in all 'DESCRIPTION=3D' fields (except "etc.= " case) > >=20 > > Long story: > >=20 > > As you may know newest portage release 2.2.11 > > got a minor (but chatty) QA warning: > > DESCRIPTION ends with a '.' character >=20 > Why is this a QA warning in the first place? Because it is a common mistake, and having the warning in-place should help people avoid repeating it. > I don't recall a policy mandating that descriptions can't end with '.'. I > asked our QA lead about it and was told that he didn't recall that we > have an official policy about it either. Also, the devmanual never > mentions any such requirement. I don't know if and where it is documented but that's what I was taught when I started contributing to Gentoo, and it pretty much follows the common sense. DESCRIPTION is supposed to be short and descriptive. So you do an elliptical sentence (if I got the right translation), and that doesn't end with a dot. If you have any fair reason to not follow this, please speak of it. Otherwise, this is pure bikeshed and waste of time. This thread already took much more time than fixing your packages if repoman complained about them. > If someone can point me to something I'm missing, let me know. > Otherwise, I think the warning should be removed. Even if there were no written-down policy, why would it be removed? What is the benefit of removing the check that resulted in many fixes already? Do you want to revert the removals afterwards? Or do you want to introduce new packages which use '.' there? --=20 Best regards, Micha=B3 G=F3rny --Sig_/4Wzh1hJUmi3h=v7CNsXO8Ia Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJT6mD2XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ2REJCMDdDQzRGMERBRDA2RUEwQUZFNDFC MDdBMUFFQUVGQjQ0NjRFAAoJELB6GurvtEZOYsAP/ji4k9895xliRw/BdTLZ60No UssUR75frqRPYQ9jvQ6bo0/3F9teSVidYKEEfasQfeFocgoHxzeRFrdcsYsxs7j6 ag1uCQcSQsGuwHnYNvW/AJVWJyzcbA1FrRkDhJCM6psGOCNnThaw1XzIz9+xNZH5 2Zc8w1nVBj5eGuA2r+yDwiR4Xew0TjTcD6AUJgS1wHXGItu+ou5pD19bSacgpxYI 2paVOtA9a8fYyvQl5WthMG8bt0y3VpuEqsk6LM98Uph/yjBoIUHt3ORn7EJqFUfJ kjLuhboYg1vxb9lIH4tegPXFML6ILVVj8odeAZpGtq+AMvSHMNzegZRPpWU7r4m+ 5lwcwiYL/8uCWVrnwDV1CehVvpkCOhh1KD+gbZylfBUO6GIc6Ti5SfChEU2QRZXg ixHYOUCvsymQHPgdkAqFUVXLFn12UqbdaydZNmmAonqk0cnNoY1jqg76TP4g55y3 xBsNiCTP6hXXQsToGaLun4baoJaRMCbiZcONvwXVdP4aY2wVPiNnxgKTefb6zAWn PuEwpVygjc0YfBSLwEK5EKC4Qa6yu8Vj4nqu7dEpGif8ywy/QL8pyGhUW1G2pbw8 DtIlbxtde0pHkDc1WQvK9wGVJGfd9Pkuk891DAs1bj7D83TVOaxl7qP+lPf+WqvB fJkA3S5uLRU1Oe2kRb/5 =4yAj -----END PGP SIGNATURE----- --Sig_/4Wzh1hJUmi3h=v7CNsXO8Ia--