[gentoo-dev] Need help with sys-fs/e2fsprogs-1.42.11 build failure

[gentoo-dev] Need help with sys-fs/e2fsprogs-1.42.11 build failure

[Lars Wendler]

[-- Attachment #1: Type: text/plain, Size: 905 bytes --]

Hi guys,

I just add e2fsprogs{,-libs}-1.42.11 p.masked to our tree as I get a
strange build failure in e2fsprogs-1.42.11:

x86_64-pc-linux-gnu-gcc -I. -I../../lib -I../../lib  -D_GNU_SOURCE
-march=barcelona -mtune=barcelona -O2 -pipe -DHAVE_CONFIG_H
-I../../debugfs -c tst_libext2fs.c -o tst_libext2fs.o make[2]: *** No
rule to make target '../../lib/libss.a', needed by 'tst_libext2fs'.
Stop. make[2]: Leaving directory
'/var/tmp/portage/sys-fs/e2fsprogs-1.42.11/work/e2fsprogs-1.42.11/lib/ext2fs'
Makefile:395: recipe for target 'all-libs-recursive' failed

The above run was with MAKEOPTS set to -j1 to make sure it's not a
parallel make issue.

I already looked into the sources but I can't figure out where the
problem comes from. Any help is highly appreciated.

Kind regards
-- 
Lars Wendler
Gentoo package maintainer
GPG: 4DD8 C47C CDFA 5295 E1A6 3FC8 F696 74AB 981C A6FC

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [gentoo-dev] Need help with sys-fs/e2fsprogs-1.42.11 build failure

[Mike Gilbert]

On Sun, Jul 20, 2014 at 6:47 AM, Lars Wendler <polynomial-c@gentoo.org> wrote:
> Hi guys,
>
> I just add e2fsprogs{,-libs}-1.42.11 p.masked to our tree as I get a
> strange build failure in e2fsprogs-1.42.11:
>
> x86_64-pc-linux-gnu-gcc -I. -I../../lib -I../../lib  -D_GNU_SOURCE
> -march=barcelona -mtune=barcelona -O2 -pipe -DHAVE_CONFIG_H
> -I../../debugfs -c tst_libext2fs.c -o tst_libext2fs.o make[2]: *** No
> rule to make target '../../lib/libss.a', needed by 'tst_libext2fs'.
> Stop. make[2]: Leaving directory
> '/var/tmp/portage/sys-fs/e2fsprogs-1.42.11/work/e2fsprogs-1.42.11/lib/ext2fs'
> Makefile:395: recipe for target 'all-libs-recursive' failed
>
> The above run was with MAKEOPTS set to -j1 to make sure it's not a
> parallel make issue.
>
> I already looked into the sources but I can't figure out where the
> problem comes from. Any help is highly appreciated.
>

This commit introduced a new test program (tst_libext2fs) which gets
build by default (see the "all" target).

https://git.kernel.org/cgit/fs/ext2/e2fsprogs.git/commit/lib/ext2fs/Makefile.in?id=ceff962c67f19724e6fffe92adfdfff0cd462722

This program gets linked with DEPSTATIC_LIBSS, which defaults to $(LIB)/libss.a.

The e2fsprogs ebuild does not build $(LIB)/libss.a; it expects that to
have been build/installed by e2fsprogs-libs.

There is a sed statement in src_prepare which replaces most of these
LIBXX variables with references to the system libs (-lss). However,
this sed statement does not replace DEPSTATIC_LIBXX.

Re: [gentoo-dev] Need help with sys-fs/e2fsprogs-1.42.11 build failure

[Jeroen Roovers]

On Sun, 20 Jul 2014 12:47:49 +0200
Lars Wendler <polynomial-c@gentoo.org> wrote:

> I just add e2fsprogs{,-libs}-1.42.11 p.masked to our tree as I get a
> strange build failure in e2fsprogs-1.42.11:

Why let that bug tracker go unused? :)


     jer

Re: [gentoo-dev] Need help with sys-fs/e2fsprogs-1.42.11 build failure

[Mike Gilbert]

On Sun, Jul 20, 2014 at 6:47 AM, Lars Wendler <polynomial-c@gentoo.org> wrote:
> Hi guys,
>
> I just add e2fsprogs{,-libs}-1.42.11

Is there some reason that we continue to maintain these as two
separate packages? It seems like the e2fsprogs ebuild could
build/install both the binaries and the libraries, and that would
probably prevent weird failures like this one.

I see this in README.subset:

Re: [gentoo-dev] Need help with sys-fs/e2fsprogs-1.42.11 build failure

[Mike Gilbert]

On Sun, Jul 20, 2014 at 11:09 AM, Mike Gilbert <floppym@gentoo.org> wrote:
> On Sun, Jul 20, 2014 at 6:47 AM, Lars Wendler <polynomial-c@gentoo.org> wrote:
>> Hi guys,
>>
>> I just add e2fsprogs{,-libs}-1.42.11
>
> Is there some reason that we continue to maintain these as two
> separate packages? It seems like the e2fsprogs ebuild could
> build/install both the binaries and the libraries, and that would
> probably prevent weird failures like this one.
>
> I see this in README.subset:

Oops, hit send too quickly.

I see this in README.subset:

---
This distribution contains a subset of the e2fsprogs package; it
contains the base libraries (ss, et, uuid, blkid) which may be used by
other non-ext2-related applications.

This may be useful for non-Linux operating systems that need these
libraries for GNOME, but who do not need the ext2/ext3 filesystem
utilities.
---

From what I can tell, e2fsprogs and e2fsprogs-libs have mostly the
same KEYWORDS with a couple of exceptions:

x86-fbsd
x86-freebsd
x86-solaris

It hardly seems worth the effort to maintain 2 ebuilds for these small
platforms.

Re: [gentoo-dev] Need help with sys-fs/e2fsprogs-1.42.11 build failure

[Lars Wendler]

[-- Attachment #1: Type: text/plain, Size: 556 bytes --]

On Sun, 20 Jul 2014 16:56:55 +0200 Jeroen Roovers wrote:

>On Sun, 20 Jul 2014 12:47:49 +0200
>Lars Wendler <polynomial-c@gentoo.org> wrote:
>
>> I just add e2fsprogs{,-libs}-1.42.11 p.masked to our tree as I get a
>> strange build failure in e2fsprogs-1.42.11:
>
>Why let that bug tracker go unused? :)
>
>
>     jer
>

Sorry my fault. I didn't look if there's a bug open for it. Thanks for
pointing that out and add me to CC.

Cheers
-- 
Lars Wendler
Gentoo package maintainer
GPG: 4DD8 C47C CDFA 5295 E1A6 3FC8 F696 74AB 981C A6FC

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [gentoo-dev] Need help with sys-fs/e2fsprogs-1.42.11 build failure

[Lars Wendler]

[-- Attachment #1: Type: text/plain, Size: 1396 bytes --]

On Sun, 20 Jul 2014 11:12:17 -0400 Mike Gilbert wrote:

>On Sun, Jul 20, 2014 at 11:09 AM, Mike Gilbert <floppym@gentoo.org>
>wrote:
>> On Sun, Jul 20, 2014 at 6:47 AM, Lars Wendler
>> <polynomial-c@gentoo.org> wrote:
>>> Hi guys,
>>>
>>> I just add e2fsprogs{,-libs}-1.42.11
>>
>> Is there some reason that we continue to maintain these as two
>> separate packages? It seems like the e2fsprogs ebuild could
>> build/install both the binaries and the libraries, and that would
>> probably prevent weird failures like this one.
>>
>> I see this in README.subset:
>
>Oops, hit send too quickly.
>
>I see this in README.subset:
>
>---
>This distribution contains a subset of the e2fsprogs package; it
>contains the base libraries (ss, et, uuid, blkid) which may be used by
>other non-ext2-related applications.
>
>This may be useful for non-Linux operating systems that need these
>libraries for GNOME, but who do not need the ext2/ext3 filesystem
>utilities.
>---
>
>From what I can tell, e2fsprogs and e2fsprogs-libs have mostly the
>same KEYWORDS with a couple of exceptions:
>
>x86-fbsd
>x86-freebsd
>x86-solaris
>
>It hardly seems worth the effort to maintain 2 ebuilds for these small
>platforms.
>

I think vapier could shed some light on this.

-- 
Lars Wendler
Gentoo package maintainer
GPG: 4DD8 C47C CDFA 5295 E1A6 3FC8 F696 74AB 981C A6FC

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [gentoo-dev] Need help with sys-fs/e2fsprogs-1.42.11 build failure

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 1747 bytes --]

On Sun 20 Jul 2014 11:12:17 Mike Gilbert wrote:
> On Sun, Jul 20, 2014 at 11:09 AM, Mike Gilbert wrote:
> > Is there some reason that we continue to maintain these as two
> > separate packages? It seems like the e2fsprogs ebuild could
> > build/install both the binaries and the libraries, and that would
> > probably prevent weird failures like this one.
> 
> > I see this in README.subset:
> Oops, hit send too quickly.
> 
> I see this in README.subset:
> 
> ---
> This distribution contains a subset of the e2fsprogs package; it
> contains the base libraries (ss, et, uuid, blkid) which may be used by
> other non-ext2-related applications.
> 
> This may be useful for non-Linux operating systems that need these
> libraries for GNOME, but who do not need the ext2/ext3 filesystem
> utilities.
> ---

e2fsprogs-libs was added because it provided those 4 libs which other packages 
were using and people did not like depending on sys-fs/e2fsprogs to get them 
(most significantly libuuid), which is not unreasonable.  since then, 
libuuid/libblkid have moved to util-linux, and the non-linux people again be 
hating on it.  see https://bugs.gentoo.org/278667.

deleting e2fsprogs-libs would busticate them badly.  at least the current 
situation allows us to keep the old version in the tree which provides 
libuuid.

the overhead here is not great imo (having done so for 6 years now), so i 
don't see a problem continuing it.

of course, the libuuid situation needs fixing up properly, but i don't have 
the inclination to sort it out, and the status-quo is still tolerable.

tl;dr: un-fsck the libuuid/libblkid situation and we probably can merge 
e2fsprogs-libs back in.  until then, not really.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]